Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42338

Remove hardcoded string in external activities

    Details

    • Testing Instructions:
      Hide
      1. Clear cache
      2. Create external tools activity
      3. visit the grade page (/mod/lti/grade.php?id=[coursemoduleid],
      • Make sure the string is displayed as before (for 2.4 and 2.5).
      • For 2.4, 2.5, and master make sure the browser's title is the same as before.
      Show
      Clear cache Create external tools activity visit the grade page (/mod/lti/grade.php?id= [coursemoduleid] , Make sure the string is displayed as before (for 2.4 and 2.5). For 2.4, 2.5, and master make sure the browser's title is the same as before.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Sprint:
      FRONTEND Sprint 6
    • Sprint:
      FRONTEND Sprint 6

      Description

      In mod/lti/grade.php, there is a hardcoded string:

      $title = 'Submissions for ' . $lti->name;

      It needs to be converted to use language string.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            The changes look good to me. Submitting for integration.

            Show
            dobedobedoh Andrew Nicols added a comment - The changes look good to me. Submitting for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Hi

            Rosie, your branch includes the blocker - if you can take that out then we can get this integrated asap

            Show
            poltawski Dan Poltawski added a comment - Hi Rosie, your branch includes the blocker - if you can take that out then we can get this integrated asap
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Dan,

            I updated the patch for master (the only branch that includes the blocker issue) and making this as independent bug.

            Thanks.

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Dan, I updated the patch for master (the only branch that includes the blocker issue) and making this as independent bug. Thanks.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, thanks Rosie

            Show
            poltawski Dan Poltawski added a comment - Integrated, thanks Rosie
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Rossie,

            I can see proper strings as before... Passing...

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Rossie, I can see proper strings as before... Passing...
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            "Aequam memento rebus in arduis servare mentem"

            Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - "Aequam memento rebus in arduis servare mentem" Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13