Affects Version/s: 2.6
Component/s: External Tool (IMS-LTI)
List of modules to test:
Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.ShowList of modules to test: chat choice data feedback forum glossary lesson lti page quiz survey wiki badges user/emailupdate.php Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.
Fixed Branches:MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
Pull 2.6 Branch:
Pull Master Branch:
Pull Master Diff URL:
Story Points (Obsolete):13
Sprint:FRONTEND Sprint 9
Both $PAGE->set_title() and $PAGE->set_heading() already process the contents passed with format_string(). So any call of this type:
- $PAGE->set_title(format_string(… (there are 42 of this, at least)
- $PAGE->set_heading(format_string(… (there are 25 of this, at least)
Context in format_string() calls is only needed if it does not match current $PAGE->context OR if it has not been set. And any of these operations set it:
- require_login() calls passing the 3rd, $cm parameter.
- $PAGE->set_cm() calls.
- $PAGE->set_context() explicit calls.
This is about to search and destroy all those incorrect uses, looking to each carefully, ensuring that context is always set.