Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42339

Remove double formatting set_title/set_heading over codebase

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      List of modules to test:

      1. chat
      2. choice
      3. data
      4. feedback
      5. forum
      6. glossary
      7. lesson
      8. lti
      9. page
      10. quiz
      11. survey
      12. wiki
      13. badges
      14. user/emailupdate.php

      Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.

      Show
      List of modules to test: chat choice data feedback forum glossary lesson lti page quiz survey wiki badges user/emailupdate.php Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Story Points:
      13
    • Sprint:
      FRONTEND Sprint 9

      Description

      Both $PAGE->set_title() and $PAGE->set_heading() already process the contents passed with format_string(). So any call of this type:

      • $PAGE->set_title(format_string(… (there are 42 of this, at least)
      • $PAGE->set_heading(format_string(… (there are 25 of this, at least)

      Context in format_string() calls is only needed if it does not match current $PAGE->context OR if it has not been set. And any of these operations set it:

      • require_login() calls passing the 3rd, $cm parameter.
      • $PAGE->set_cm() calls.
      • $PAGE->set_context() explicit calls.

      This is about to search and destroy all those incorrect uses, looking to each carefully, ensuring that context is always set.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41797 Fix heading for external tools activities

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-69464 Option to allow HTML in the page headings (skip applying format_string)

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              rwijaya Rossiani Wijaya
              Reporter:
              rwijaya Rossiani Wijaya
              Peer reviewer:
              Jérôme Mouneyrac Jérôme Mouneyrac
              Integrator:
              Marina Glancy Marina Glancy
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14