Moodle
  1. Moodle
  2. MDL-42352

Edit PDF: Page scrolling when clicking on menus

    Details

      Description

      If you click on the page menu in the corner of the comment, the page scrolls up.

      Tested with: Chrome, Debian + KDE.

      See attached video.

        Gliffy Diagrams

          Activity

          Hide
          Davo Smith added a comment -

          Added lots of 'preventDefault' calls to stop the unwanted scrolling.

          Show
          Davo Smith added a comment - Added lots of 'preventDefault' calls to stop the unwanted scrolling.
          Hide
          Damyon Wiese added a comment -

          Thanks for helping out Davo. This looks like the correct solution to me - and this is an important fix. Sending to integration (I added testing instructions).

          [Y] Syntax
          [Y] Whitespace
          [-] Output
          [-] Language
          [-] Databases
          [Y (because I added them)] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [Y] Git
          [-] Third party code
          [Y] Sanity check

          Show
          Damyon Wiese added a comment - Thanks for helping out Davo. This looks like the correct solution to me - and this is an important fix. Sending to integration (I added testing instructions). [Y] Syntax [Y] Whitespace [-] Output [-] Language [-] Databases [Y (because I added them)] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check
          Hide
          Dan Poltawski added a comment -

          Integrated to master - thanks Davo

          Show
          Dan Poltawski added a comment - Integrated to master - thanks Davo
          Hide
          Adrian Greeve added a comment -

          Tested on the master integration branch.
          Clicking on the comment context menu did not result it any scrolling.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the master integration branch. Clicking on the comment context menu did not result it any scrolling. Test passed.
          Hide
          Dan Poltawski added a comment -

          Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

          Show
          Dan Poltawski added a comment - Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: