Moodle
  1. Moodle
  2. MDL-42355

Edit PDF: Difficult to stop adding comments

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Assignment
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Open the EditPDF interface
      2. Select the comment tool
      3. Click to add a comment somewhere
      4. Click outside the comment
      5. Verify the blank comment disappears and no new comment is added
      6. Click again
      7. Verify a new comment appears
      8. Type some text in the new comment
      9. Click outside the comment
      10. Verify the comment does not disappear, but no new comment is added
      11. Click again
      12. Verify a new comment is added
      Show
      Open the EditPDF interface Select the comment tool Click to add a comment somewhere Click outside the comment Verify the blank comment disappears and no new comment is added Click again Verify a new comment appears Type some text in the new comment Click outside the comment Verify the comment does not disappear, but no new comment is added Click again Verify a new comment is added
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42355_editpdf_deselect_comment

      Description

      Create a comment.
      Click off the comment, somewhere else on the page and Moodle starts creating a new comment (with the old version, clicking saved a comment but did not start creating a new comment - you had to click a second time in order to do that).

      This makes it quite difficult to just stop inserting comments, so that you can read the text on the page.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Davo Smith added a comment -

            This prevents a new comment from appearing immediately after you have clicked off another comment you were editing. This (to my mind) makes for a much more user-friendly editing process and, as an added bonus, fixes MDL-42351 at the same time.

            Show
            Davo Smith added a comment - This prevents a new comment from appearing immediately after you have clicked off another comment you were editing. This (to my mind) makes for a much more user-friendly editing process and, as an added bonus, fixes MDL-42351 at the same time.
            Hide
            Davo Smith added a comment -

            Note this branch builds on the branches for MDL-42352 and MDL-42482, so those two should be looked at / integrated first.

            Show
            Davo Smith added a comment - Note this branch builds on the branches for MDL-42352 and MDL-42482 , so those two should be looked at / integrated first.
            Hide
            Andrew Nicols added a comment -

            I've just had a chat with Damyon and we both feel that the current approach is correct.

            Whilst using the comment tool, clicking should always create a new comment.
            If you create a comment, but initially put it in the wrong location, you want to be able to create a new comment whilst using the comment tool.

            Show
            Andrew Nicols added a comment - I've just had a chat with Damyon and we both feel that the current approach is correct. Whilst using the comment tool, clicking should always create a new comment. If you create a comment, but initially put it in the wrong location, you want to be able to create a new comment whilst using the comment tool.
            Hide
            Davo Smith added a comment -

            Have either of you tried to use the comment tool to do real marking?

            Currently it is very difficult to make a comment then go back to reading the page, without another comment immediately popping up (you have to click somewhere off the page to do that). By comparison with something like Word, you have to double-click on the 'textbox' icon if you want to create multiple text boxes.

            If you create a comment and it is in the wrong place, then it is possible to immediately drag the comment to a new location. If you really just want to stop adding a comment where it is (which I don't think is anywhere near as common as the need to stop adding comments and ready the page again), then start adding it in a new location, then you can click once to remove the current comment and click a second time to add a new comment.

            Show
            Davo Smith added a comment - Have either of you tried to use the comment tool to do real marking? Currently it is very difficult to make a comment then go back to reading the page, without another comment immediately popping up (you have to click somewhere off the page to do that). By comparison with something like Word, you have to double-click on the 'textbox' icon if you want to create multiple text boxes. If you create a comment and it is in the wrong place, then it is possible to immediately drag the comment to a new location. If you really just want to stop adding a comment where it is (which I don't think is anywhere near as common as the need to stop adding comments and ready the page again), then start adding it in a new location, then you can click once to remove the current comment and click a second time to add a new comment.
            Hide
            Andrew Nicols added a comment -

            Heh, as it happens, I was just about to comment and say that I'd rethought that having poked it for quite a bit this morning

            Show
            Andrew Nicols added a comment - Heh, as it happens, I was just about to comment and say that I'd rethought that having poked it for quite a bit this morning
            Hide
            Andrew Nicols added a comment -

            Note, this does not resolve MDL-42351

            Show
            Andrew Nicols added a comment - Note, this does not resolve MDL-42351
            Hide
            Davo Smith added a comment -

            Andrew - given that you have rethought this, would this now be OK to put forward for integration?

            Show
            Davo Smith added a comment - Andrew - given that you have rethought this, would this now be OK to put forward for integration?
            Hide
            Damyon Wiese added a comment -

            Doing some more testing with this now.

            Show
            Damyon Wiese added a comment - Doing some more testing with this now.
            Hide
            Damyon Wiese added a comment -

            Thanks Davo I did some testing with this patch and I agree it's better. The main improvement is when you click to add a comment by mistake and just want the comment box to go away.

            [Y] Syntax
            [-] Whitespace
            [-] Output
            [-] Language
            [-] Databases
            [Y (I added them)] Testing (instructions and automated tests)
            [-] Security
            [-] Documentation
            [Y] Git
            [-] Third party code
            [Y] Sanity check

            Show
            Damyon Wiese added a comment - Thanks Davo I did some testing with this patch and I agree it's better. The main improvement is when you click to add a comment by mistake and just want the comment box to go away. [Y] Syntax [-] Whitespace [-] Output [-] Language [-] Databases [Y (I added them)] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check
            Hide
            Davo Smith added a comment -

            Thanks Damyon & Andrew - it's a subtle change, but it just feels more in line with how the user will normally want it to behave.

            Show
            Davo Smith added a comment - Thanks Damyon & Andrew - it's a subtle change, but it just feels more in line with how the user will normally want it to behave.
            Hide
            Dan Poltawski added a comment -

            Thanks Davo, integrated to master

            Show
            Dan Poltawski added a comment - Thanks Davo, integrated to master
            Hide
            Petr Skoda added a comment -

            works for me, thanks

            Show
            Petr Skoda added a comment - works for me, thanks
            Hide
            Eloy Lafuente (stronk7) added a comment -

            It's Friday, I'm tired so I won't be very imaginative today.

            No matter of that, yes, you did it! Thanks for your collaboration!

            Closing this as fixed!

            Show
            Eloy Lafuente (stronk7) added a comment - It's Friday, I'm tired so I won't be very imaginative today. No matter of that, yes, you did it! Thanks for your collaboration! Closing this as fixed!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: