[MDL-42366] Edit PDF: Wrong cursor when students view online - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6, 3.3.2, 3.3.3, 3.4, 3.4.1
Fix Version/s: 3.6
Component/s: Assignment
Labels:
- ci
- patch

Affected Branches:
MOODLE_26_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_36_STABLE
Epic Link:
Add Upload PDF to core
Pull from Repository:
https://github.com/lucisgit/moodle
Pull Master Branch:
~~MDL-42366~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...lucisgit:MDL-42366-master
Testing Instructions:
Hide

As a teacher, create an assignment with assignfeedback_editpdf enabled.

As a student, submit to the assignment.

As a teacher, grade the submission and annotate some feedback. Verify that:

With the 'stamp' tool selected, the cursor changes to the currently selected stamp image.

With the 'highlight' tool selected, the cursor changes to the 'text' cursor style and the positioning of highlights is accurate.

With the 'select' tool selected, the cursor changes to the 'default' (arrow) cursor style (and the 'pointer' style only when hovering over the 'delete' icon of a selected annotation).

Release the grade and feedback.

As a student, view the annotated PDF using the online viewer and verify that the 'default' (arrow) cursor style is used when hovering over the document.
Show
As a teacher, create an assignment with assignfeedback_editpdf enabled. As a student, submit to the assignment. As a teacher, grade the submission and annotate some feedback. Verify that: With the 'stamp' tool selected, the cursor changes to the currently selected stamp image. With the 'highlight' tool selected, the cursor changes to the 'text' cursor style and the positioning of highlights is accurate. With the 'select' tool selected, the cursor changes to the 'default' (arrow) cursor style (and the 'pointer' style only when hovering over the 'delete' icon of a selected annotation). Release the grade and feedback. As a student, view the annotated PDF using the online viewer and verify that the 'default' (arrow) cursor style is used when hovering over the document.

Description

Minor point:

If a student views the PDF annotations online, then they get a 'crosshair' cursor, implying that it is possible for them to interact with the page in some manner. This is not the case, as the page is in 'read-only' mode.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2018-06-06-10-16-19-948.png
407 kB
06/Jun/18 6:16 PM

Activity

People

Assignee:: Tony Butler

Reporter:: Davo Smith

Peer reviewer:: Mark Johnson

Integrator:: David Monllaó

Tester:: Janelle Barcega

Participants:: CiBoT, David Monllaó, Davo Smith, Eloy Lafuente (stronk7), Janelle Barcega, Mark Johnson, Tony Butler

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 15/Oct/13 8:34 PM

Updated:: 08/Jun/18 9:38 AM

Resolved:: 08/Jun/18 9:38 AM

Fix Release Date:: 3/Dec/18

Time Tracking

Estimated:

Remaining:

Logged:

27m