Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42368

Anomaly theme long breadcrumb trail hides the "Turn editing on" button

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2, 2.6.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Enable Anomaly theme
      2. Go to a course or any page with medium or large breadcrumb length.
      3. Resize the window width so it crushes the breadcrumb together.
      4. Notice how half of the breadcrumb gets hidden along with the "Turn editing on" button.

      Show
      1. Enable Anomaly theme 2. Go to a course or any page with medium or large breadcrumb length. 3. Resize the window width so it crushes the breadcrumb together. 4. Notice how half of the breadcrumb gets hidden along with the "Turn editing on" button.
    • Workaround:
      Hide

      Simple workaround is to remove the "height: 30px;" property from theme/anomaly/style/general.css line 69 and add "padding-bottom: 5px;" to keep the current outlook.

      Show
      Simple workaround is to remove the "height: 30px;" property from theme/anomaly/style/general.css line 69 and add "padding-bottom: 5px;" to keep the current outlook.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull 2.6 Branch:
    • Pull Master Branch:
      MDL-42368-master

      Description

      When the breadcrumb trail is longer then the screen size, then the breadcrumb is shown in multiple lines, but the HTML element "#page-header .navbar" has CSS property "height: 30px;" so only the first line will be visible.

      Also the "Turn editing on" button gets invisible this way.

        Gliffy Diagrams

          Activity

          Hide
          kriv Krister Viirsaar added a comment -

          Strange that this issue has not been fixed yet. To help along I've done a few things:

          1. Tested the suggestion - works great.
          2. Made a patch for merging.
          3. Asked for a peer review.

          Show
          kriv Krister Viirsaar added a comment - Strange that this issue has not been fixed yet. To help along I've done a few things: 1. Tested the suggestion - works great. 2. Made a patch for merging. 3. Asked for a peer review.
          Show
          cibot CiBoT added a comment - Results for MDL-42368 Remote repository: https://github.com/KristerV/moodle Remote branch MDL-42368 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/946 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/946/artifact/work/smurf.html
          Hide
          poltawski Dan Poltawski added a comment -

          Hello Krister,

          Thanks for this nice simple fix. Apologies that it has taken so long to get reviewed.

          I've tested the fix and seems to work perfectly. I've backported your change to 26 and 25 and i'm sending this for integration.

          Show
          poltawski Dan Poltawski added a comment - Hello Krister, Thanks for this nice simple fix. Apologies that it has taken so long to get reviewed. I've tested the fix and seems to work perfectly. I've backported your change to 26 and 25 and i'm sending this for integration.
          Hide
          cibot CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Krister, this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Krister, this has been integrated now.
          Hide
          jethac Jetha Chan added a comment -

          Started testing.

          Show
          jethac Jetha Chan added a comment - Started testing.
          Hide
          jethac Jetha Chan added a comment -

          Test passed on 2.5, 2.6 and integration master.

          Show
          jethac Jetha Chan added a comment - Test passed on 2.5, 2.6 and integration master.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The price of success is hard work,
          dedication to the job at hand,
          and the determination that whether we win or lose,
          we have applied the best of ourselves to the task at hand.

          Vince Lombardi

          This is now part of Moodle, your favorite non-frameworkial LMS, LOL. Thanks, closing!

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The price of success is hard work, dedication to the job at hand, and the determination that whether we win or lose, we have applied the best of ourselves to the task at hand. Vince Lombardi This is now part of Moodle, your favorite non-frameworkial LMS, LOL. Thanks, closing! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14