Hello David,

This behat test incorporates approving and disapproving glossary entries. It should follow pretty closely the MDLQA test that it is replacing.

Please note that the 2.5 backport is missing the disapproval section of the test.

Thanks.

Hi Adrian,

Thanks for the conversion, it looks all good, just commenting a couple of minor points:

• Follow the YAML indentation format (http://docs.behat.org/guides/1.gherkin.html#gherkin-syntax) you can see many examples in the other .feature files
• You can reword the 2.5 branch commit message to remove the disapproval references

Hello David,

• I've added an indent to the Feature description (That is the only thing that I could spot that seemed different to the other files and the article that you posted a link to) I hope that is right.

• I updated this commit message to remove mention of disapproval.

As I'm still unsure about the formatting of these feature files if you could please have another look for me.

Thanks.

Looks good Adrian

Hi David,

I hope that I have this right and you have just forgotten to click the "finish peer review" button.
I'm sending this to integration.

Yes yes, I forgot to click it

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Adrian this has been integrated now.

Tested during integration review.

FYI: related MDLQA-34 has been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

Linking unapproval of glossary entries MDLQA as it is already being tested here. Moving the MDLQA issue with the converted to behat ones.

Note: getting rid of the mdlqa_conversion label here. Related MDLQA have been already moved to MDLQA-5249. Thanks!