Moodle
  1. Moodle
  2. MDL-42379

Automate MDLQA-34 - A teacher can set that glossary entries require approval before being viewable by everyone

    Details

    • Sprint:
      BACKEND Sprint 6

      Description

      As described in MDLQA-34, a teacher can set that glossary entries require approval before being viewable by everyone

      Only in master: This feature should also include unapproval of entries (https://tracker.moodle.org/browse/MDL-29069)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Adrian Greeve added a comment - - edited

            Hello David,

            This behat test incorporates approving and disapproving glossary entries. It should follow pretty closely the MDLQA test that it is replacing.

            Please note that the 2.5 backport is missing the disapproval section of the test.

            Thanks.

            Show
            Adrian Greeve added a comment - - edited Hello David, This behat test incorporates approving and disapproving glossary entries. It should follow pretty closely the MDLQA test that it is replacing. Please note that the 2.5 backport is missing the disapproval section of the test. Thanks.
            Hide
            David Monllaó added a comment -

            Hi Adrian,

            Thanks for the conversion, it looks all good, just commenting a couple of minor points:

            Show
            David Monllaó added a comment - Hi Adrian, Thanks for the conversion, it looks all good, just commenting a couple of minor points: Follow the YAML indentation format ( http://docs.behat.org/guides/1.gherkin.html#gherkin-syntax ) you can see many examples in the other .feature files You can reword the 2.5 branch commit message to remove the disapproval references
            Hide
            Adrian Greeve added a comment -

            Hello David,

            • I've added an indent to the Feature description (That is the only thing that I could spot that seemed different to the other files and the article that you posted a link to) I hope that is right.
            • I updated this commit message to remove mention of disapproval.

            As I'm still unsure about the formatting of these feature files if you could please have another look for me.

            Thanks.

            Show
            Adrian Greeve added a comment - Hello David, I've added an indent to the Feature description (That is the only thing that I could spot that seemed different to the other files and the article that you posted a link to) I hope that is right. I updated this commit message to remove mention of disapproval. As I'm still unsure about the formatting of these feature files if you could please have another look for me. Thanks.
            Hide
            David Monllaó added a comment -

            Looks good Adrian

            Show
            David Monllaó added a comment - Looks good Adrian
            Hide
            Adrian Greeve added a comment -

            Hi David,

            I hope that I have this right and you have just forgotten to click the "finish peer review" button.
            I'm sending this to integration.

            Show
            Adrian Greeve added a comment - Hi David, I hope that I have this right and you have just forgotten to click the "finish peer review" button. I'm sending this to integration.
            Hide
            David Monllaó added a comment -

            Yes yes, I forgot to click it

            Show
            David Monllaó added a comment - Yes yes, I forgot to click it
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Sam Hemelryk added a comment -

            Thanks Adrian this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Adrian this has been integrated now.
            Hide
            Sam Hemelryk added a comment -

            Tested during integration review.

            Show
            Sam Hemelryk added a comment - Tested during integration review.
            Hide
            Sam Hemelryk added a comment -

            FYI: related MDLQA-34 has been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!

            Show
            Sam Hemelryk added a comment - FYI: related MDLQA-34 has been moved from MDLQA-1 to MDLQA-5249 (bag of behat-converted tests). Thanks!
            Hide
            Dan Poltawski added a comment -

            Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

            Show
            Dan Poltawski added a comment - Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.
            Hide
            David Monllaó added a comment -

            Linking unapproval of glossary entries MDLQA as it is already being tested here. Moving the MDLQA issue with the converted to behat ones.

            Show
            David Monllaó added a comment - Linking unapproval of glossary entries MDLQA as it is already being tested here. Moving the MDLQA issue with the converted to behat ones.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Note: getting rid of the mdlqa_conversion label here. Related MDLQA have been already moved to MDLQA-5249. Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Note: getting rid of the mdlqa_conversion label here. Related MDLQA have been already moved to MDLQA-5249 . Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile