Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42386

Etag verification for stored files never matching

XMLWordPrintable

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • w43_MDL-42386_m26_etag
    • Hide

      1/ create forum post with some embedded image
      2/ use developer tools to verify 304 is sent on the next page visit (not reload)

      Show
      1/ create forum post with some embedded image 2/ use developer tools to verify 304 is sent on the next page visit (not reload)
    • 2
    • BACKEND Sprint 6

      Doing some innocent testing of MDL-38743 it was discovered that etag verification (and last-modified verification consequently) were no matching ever.

      See point B2 in that issue.

      This is about to fix the etag matching over all stable branches.

      It has a big impact in pages heavily using stored files (forum discussions… long books… long courses with labels…)

      I reviewed all the rest of etag uses in code base (js, css, yui combo…) and all them seemed to be using the /revision/ approach, so they are not affected. In any case I'd recommend to review all them again, just in case I missed anything.

            skodak Petr Skoda
            stronk7 Eloy Lafuente (stronk7)
            Dan Poltawski Dan Poltawski
            Marina Glancy Marina Glancy
            Jérôme Mouneyrac Jérôme Mouneyrac
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.