Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42386

Etag verification for stored files never matching

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1/ create forum post with some embedded image
      2/ use developer tools to verify 304 is sent on the next page visit (not reload)

      Show
      1/ create forum post with some embedded image 2/ use developer tools to verify 304 is sent on the next page visit (not reload)
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w43_MDL-42386_m26_etag
    • Story Points:
      2
    • Sprint:
      BACKEND Sprint 6

      Description

      Doing some innocent testing of MDL-38743 it was discovered that etag verification (and last-modified verification consequently) were no matching ever.

      See point B2 in that issue.

      This is about to fix the etag matching over all stable branches.

      It has a big impact in pages heavily using stored files (forum discussions… long books… long courses with labels…)

      I reviewed all the rest of etag uses in code base (js, css, yui combo…) and all them seemed to be using the /revision/ approach, so they are not affected. In any case I'd recommend to review all them again, just in case I missed anything.

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            Dan Poltawski
            Integrator:
            Marina Glancy
            Tester:
            Jérôme Mouneyrac
            Participants:
            Component watchers:
            Matteo Scaramuccia, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Matteo Scaramuccia, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Nov/13