Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42392

Block content doesn't show when the content was hidden and javascript is turned off

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.1, 2.6, 2.7
    • Fix Version/s: 2.5.4, 2.6.1
    • Component/s: Blocks, Themes
    • Labels:
    • Testing Instructions:
      Hide

      In all core themes:

      • Add a block
      • Hide it using the [-] button
        • Confirm it's content is hidden
      • Disable JS and refresh
        • Confirm it's content is visible again and the block show/hide preference control is absent
      Show
      In all core themes: Add a block Hide it using the [-] button Confirm it's content is hidden Disable JS and refresh Confirm it's content is visible again and the block show/hide preference control is absent
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42392-master
    • Story Points:
      3
    • Sprint:
      FRONTEND Sprint 7

      Description

      It is not possible to unhide a block when JavaScript is disabled.

      As a result, if a block is hidden (a per-user preference), then it cannot be unhidden if a user has since turned JavaScript off.

      We should either add a show button which reloads the page, or we should unhide the content when JS is disabled.

      I vote the latter as I think we should try and encourage users not to disable JavaScript.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            rloconne Rebecca O'Connell
            Peer reviewer:
            Petr Skoda
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/14