Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42428

Update M.util.show_confirm_dialog() to use moodle-core-notification

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Ideally we should test anywhere that the existing show_confirm_dialog is in use.

      Note: Have the JS console open and set to catch uncaught exceptions when running this.

      For each set of these instructions, I'd advise:

      1. Click the no/cancel option
      2. Confirm the dialogue closed
      3. Perform the action which displayed the dialogue again (e.g. clicking the 'X' button)
      4. Click the yes/continue option
      5. Confirm the dialogue closed
      6. Confirm the action performed as expected
      • Create a new assignment
      • Set the Grading Method to "Rubric"
      • Save and Display
      • Define a new Rubric from Scratch
      • Add a new Level (a new cell with a points value)
      • Click the 'X' to delete that Level
        • Run the above instruction set
      • Click the 'X' to delete the whole Criterion (the row)
        • Run the above instruction set
      • Cancel the Rubric creation
      • Re-edit the assignment
      • Change the grading method to 'Marking guide'
      • Choose "Save and Display"
      • Under 'Marking guide', add a Criterion
      • Click the 'X' to delete that criterion
        • Run the above instruction set
      • Create a quiz with a single basic question (any type)
      • Preview the quiz and fill it in
      • When prompted click the 'Submit all and finish' button
        • Run the above instruction set
      • Attempt the quiz as a student and submit it
      • As a teacher, choose 'Results' from the quiz administration
      • View the 'enrolled users who have attempted the quiz' report (should be the default)
      • Choose the user
      • Click the 'Delete selected attempts' button
        • Run the above instruction set
      Show
      Ideally we should test anywhere that the existing show_confirm_dialog is in use. Note: Have the JS console open and set to catch uncaught exceptions when running this. For each set of these instructions, I'd advise: Click the no/cancel option Confirm the dialogue closed Perform the action which displayed the dialogue again (e.g. clicking the 'X' button) Click the yes/continue option Confirm the dialogue closed Confirm the action performed as expected Create a new assignment Set the Grading Method to "Rubric" Save and Display Define a new Rubric from Scratch Add a new Level (a new cell with a points value) Click the 'X' to delete that Level Run the above instruction set Click the 'X' to delete the whole Criterion (the row) Run the above instruction set Cancel the Rubric creation Re-edit the assignment Change the grading method to 'Marking guide' Choose "Save and Display" Under 'Marking guide', add a Criterion Click the 'X' to delete that criterion Run the above instruction set Create a quiz with a single basic question (any type) Preview the quiz and fill it in When prompted click the 'Submit all and finish' button Run the above instruction set Attempt the quiz as a student and submit it As a teacher, choose 'Results' from the quiz administration View the 'enrolled users who have attempted the quiz' report (should be the default) Choose the user Click the 'Delete selected attempts' button Run the above instruction set
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-42428-master
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 9

      Description

      After confirming it with Andrew Nicols the confirm dialogues in the rubrics form and quiz completion are not converted to moodle-dialogue

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14