Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
https://github.com/markn86/moodle.git
Pull Main Branch:
~~MDL-42429~~_master
Pull Main Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-42429_master
Testing Instructions:
1. Add a lesson to a course.
2. Click to edit this lesson after it has been created.
3. Ensure there is no PHP notice.

Add a lesson to a course.
Click to edit this lesson.
You will get a PHP notice "Notice: Undefined property: stdClass::$version in /var/www/mstorage/sm/moodle/mod/lesson/mod_form.php on line 321" displaying.

It seems the global $module variable no longer stores the version.

This check seems really unnecessary as we know the module version is not going to be less than what is stated. I am just removing it.

is a regression caused by

MDL-11090 Password in lesson not visible at settings page

is duplicated by

MDL-42384 error Notice in Lesson edit page

MDL-42650 Warning on edit lesson page

Testing discovered

MDL-40054 Replace add_to_log with an event trigger - mod_lesson

Participants:: Ankit Agarwal, Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart, Marina Glancy, Mark Nelson