Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
wip-~~MDL-42441~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/moodle:master...wip-MDL-42441-master
Testing Instructions:
Hide

Enable some group mode in the course but do not force it

Drag and drop scorm package on the page

Make sure the group mode for activity is displayed properly

Refresh the page

Make sure the group mode for activity is displayed properly

Drag and drop scorm package on page again

Without refreshing the page try to change the group mode, make sure it is being changed properly and remains the same after refreshing the page

Repeat the same with forced group mode (except that you should not be able to change the group mode in this case)
Show
Enable some group mode in the course but do not force it Drag and drop scorm package on the page Make sure the group mode for activity is displayed properly Refresh the page Make sure the group mode for activity is displayed properly Drag and drop scorm package on page again Without refreshing the page try to change the group mode, make sure it is being changed properly and remains the same after refreshing the page Repeat the same with forced group mode (except that you should not be able to change the group mode in this case)

Uploading a SCORM package using drag&drop gives these 2 debugging messages below, visible only in the web server error log file:

Debugging: It is not allowed to set the property cm_info::$groupmodelink

line 1249 of /lib/modinfolib.php: call to debugging()

line 703 of /course/dnduploadlib.php: call to cm_info->__set()

line 553 of /course/dnduploadlib.php: call to dndupload_ajax_processor->finish_setup_course_module()

line 515 of /course/dnduploadlib.php: call to dndupload_ajax_processor->handle_file_upload()

line 41 of /course/dndupload.php: call to dndupload_ajax_processor->process()

referer: /course/view.php?id=3&notifyeditingon=1

Debugging: It is not allowed to set the property cm_info::$groupmode

line 1249 of /lib/modinfolib.php: call to debugging()

line 704 of /course/dnduploadlib.php: call to cm_info->__set()

line 553 of /course/dnduploadlib.php: call to dndupload_ajax_processor->finish_setup_course_module()

line 515 of /course/dnduploadlib.php: call to dndupload_ajax_processor->handle_file_upload()

line 41 of /course/dndupload.php: call to dndupload_ajax_processor->process()

referer: /course/view.php?id=3&notifyeditingon=1

Regression from ~~MDL-41219~~?

has a non-specific relationship to

MDL-33057 Rewrite DND Upload to YUI module (performance)

is a regression caused by

MDL-41192 Performance and usability improvements in class cm_info

Participants:: Andrew Lyons, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Matteo Scaramuccia, Petr Skoda