Thanks for suggesting this.

Feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a "patch" label so we will spot it.

Easy thing, thought I don't really understand why Moodle has two identical functions in different files. Well, maybe it has it's reasons...

Results for MDL-42456

• Remote repository: https://github.com/oasychev/moodle

• Remote branch MDL-42456 to be integrated into upstream master
  • Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/795
  • Details: http://integration.moodle.org/job/Precheck%20remote%20branch/795/artifact/work/smurf.html

Hi, Michael and everyone. You may not getting e-mails for this issue updates due to general problems on tracker, please look at it - there is a code patch there now.

Hi Oleg,

Thanks a lot for the patch!

1. I'm not clear why we have two of these functions either - my first thought was that this was because one was a duplicate of the limited functions used for the Moodle deployer (which doesn't have whole Moodle environment available). However, as far as I can see that doesn't look to be the case. I'm wondering if David Mudrak can shed any light on that.
2. As a bug this fix should be back ported to our supported stable branches (26 and 25 as well as master). Could you provide branches for those?
3. It would be helpful for the tester if you could provide a sample hg plugin which does this - do you happen to know of one? Which could be used?

thanks!
Dan

Hi guys

to be completely honest, I can't remember why the functionality is copied there. One potential reason could be that at the time when the original deployer class was written, it was pretty expensive to get the instance of the plugin_manager. It used to load all installed plugins etc as it was intended to display those full overview pages. So maybe my reasoning was that it was not worth of initializing the full plugin_manager just to check if there are some directories present. And thence maybe I decided that copying the method was lesser of two evils.

However, I know that the whole machinery has evolved a bit since those times. But I'm really not involved much in this area any more. IIRC Petr Skoda got his hands dirty by digging into this recently. He might have a suggestion for eventual refactoring.

In the meantime, my +1 for this quick patch that modifies both places.

I do not see any problem with duplication now, +1 for the patch - we can refactor it later

Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

Thanks Oleg, this has been integrated now.

I tested this on 2.5 and 2.6, but not on master. There are no plugins in the Moodle plugin DB that support 2.7 (that I know of - I don't actually think it's even possible to upload a plugin for this version atm), so it will never find an update.

For 2.5 and 2.6, step 2 works, but step 3 does not. Thinking about this, I don't actually think there is ever a warning about the CVS software being used before deleting a plugin (at least I have never seen it). Are you sure this is actually supposed to occur?

Ping: Oleg / Dan / Sam,

Can you please confirm if step 3 is expected to work (Please refer Mark's comment above.)

I am sending this back for testing and will test this.

As Mark has left for the day, I will test this on his behalf.

Thanks for fixing this Oleg,

I created .hg directory and tried updating plugin and I could see mercurial message.

Steps I followed:

1. I installed registration activity
2. Decremented addon version in db and version.php
3. Went to plugin overview and could see "install update" button.
4. Add .hg directory to registration plugin
5. Clicked "Install update" and it showed message with Mercurial.

While uninstalling plugin, I didn't get any specific repository message, but that seems to be drawback in step 3 of testing instructions.

Passing this as patch allows moodle to detect mercurial repository as it do for git/svn/cvs.

FYI: Thanks to Dan P for helping me in testing.

This weeks weekly release is now available and includes your code.
A big pat on the back to you again for once more being a cog in the Moodle machine.

Best wishes, the Moodle integration team.

I'm sorry for not been able to respond for a week, I was on my holidays well away from the computer and internet. It seems, all get along well, thanks for all involved!