Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42456

pluginlib.php plugin_external_source() functions ignore Mercurial repositories

    Details

    • Testing Instructions:
      Hide

      1. Create a Mercurial repository holding a 3d party plugin in you Moodle installation ensuring the plugin's folder is writeable by the web server (repository folder ".hg" should be just inside you plugin directory, not outside it - e.g. version.php for example should be in the root directory of repository). You would want an obsolete version of plugin with newer version on Moodle plugin database.
      2. Try to update this plugin from Moodle Plugins database and see that you get confirmation warning about plugin been from external mercurial source and not been able to update it from repository anymore if you continue. Say "no" to updating, to be able to do next test.

      Show
      1. Create a Mercurial repository holding a 3d party plugin in you Moodle installation ensuring the plugin's folder is writeable by the web server (repository folder ".hg" should be just inside you plugin directory, not outside it - e.g. version.php for example should be in the root directory of repository). You would want an obsolete version of plugin with newer version on Moodle plugin database. 2. Try to update this plugin from Moodle Plugins database and see that you get confirmation warning about plugin been from external mercurial source and not been able to update it from repository anymore if you continue. Say "no" to updating, to be able to do next test.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      There are plugin_external_source() functions checking that plugin come from external repository. They check for CVS, SNV, Git but not Mercurial repository.

      Easy to fix one: there should be check for .hg folder there too.

      Our team use Mercurial to develop plugins.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14