Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42460

Feedback forms fail W3C Markup Validation testing due to DIV tag inside H2 tag

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As an administrator:

      1. Enable url to link filter for the content
      2. Enable the feedback module going to the admin tree -> plugins -> activity modules -> Manage activities
      3. enable $CFG->feedback_allowfullanonymous
      4. Create feedback with the name that contains url, for example "Feedback about https://moodle.org"
      5. Add an anonymous Feedback on the front page
      6. Open feedback as a guest, make sure the heading does not show link under url
      7. Click "Answer the questions"
      8. Make sure the heading does not show link under url
      Show
      As an administrator: Enable url to link filter for the content Enable the feedback module going to the admin tree -> plugins -> activity modules -> Manage activities enable $CFG->feedback_allowfullanonymous Create feedback with the name that contains url, for example "Feedback about https://moodle.org " Add an anonymous Feedback on the front page Open feedback as a guest, make sure the heading does not show link under url Click "Answer the questions" Make sure the heading does not show link under url
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42460-master
    • Pull Master Diff URL:

      Description

      Feedback forms fail W3C Markup Validation testing because a DIV tag is inside the H2 tag at the top of the content area. This is an issue regardless of the version of XHTML or HTML.

      As a result, the form fails WCAG 2.0 criterion 4.1.1 (4: Robust, 1:Compatible, 1:Parsing).

        Attachments

          Issue Links

          links to

          Web Link Fix for MDL-42460

            Activity

              People

              Assignee:
              michael-milette Michael Milette
              Reporter:
              michael-milette Michael Milette
              Peer reviewer:
              Marina Glancy
              Integrator:
              Dan Poltawski
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16