Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42476

Completion report should use feature detection rather than browser sniffing

    Details

    • Testing Instructions:
      Hide

      In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari)

      1. Enable completion tracking in advanced features
      2. In a course, enable completion tracking in the course settings
      3. Go to "completion tracking" and enable self completion and completion by date
      4. Go to course -> reports > course completion
      5. Enrol a user in the course
      6. VERIFY: no JS errors occur
      7. VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest)
      8. VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).
      Show
      In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari) Enable completion tracking in advanced features In a course, enable completion tracking in the course settings Go to "completion tracking" and enable self completion and completion by date Go to course -> reports > course completion Enrol a user in the course VERIFY: no JS errors occur VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest) VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Same issue as MDL-39964 but with completion report.

      Browser sniffing is problematic and should be avoiding. Since this feature uses JS to do its work, we should be able to use feature detection.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13