Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
https://github.com/srynot4sale/moodle.git
Pull Main Branch:
~~MDL-42476~~
Pull Main Diff URL:
https://github.com/srynot4sale/moodle/commit/d2cd4acab13928347181b9e5d7c19103283b5165
Testing Instructions:
Hide

In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari)

Enable completion tracking in advanced features

In a course, enable completion tracking in the course settings

Go to "completion tracking" and enable self completion and completion by date

Go to course -> reports > course completion

Enrol a user in the course

VERIFY: no JS errors occur

VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest)

VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).
Show
In as many browsers as possible (at least IE>9, IE8, firefox, chrome, mobilesafari) Enable completion tracking in advanced features In a course, enable completion tracking in the course settings Go to "completion tracking" and enable self completion and completion by date Go to course -> reports > course completion Enrol a user in the course VERIFY: no JS errors occur VERIFY: the text is rotated if the browser supports SVG (IE9+ and all the rest) VERIFY: the text is not rotated if the browser doesn't support SVG (IE8).

Same issue as ~~MDL-39964~~ but with completion report.

Browser sniffing is problematic and should be avoiding. Since this feature uses JS to do its work, we should be able to use feature detection.

Participants:: Aaron Barnes, Damyon Wiese, Dan Poltawski, Jason Fowler, Michael de Raadt, Rossiani Wijaya