Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42482

Edit PDF: Blank comments disappearing when you click on the menu

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Assignment
    • Labels:

      Description

      1. Click to create a new comment
      2. Click on the menu to convert it into a quicklist comment

      The comment should stay there, but instead it disappears.

      Note this is still a very fiddly way of inserting comments from the quicklist see MDL-42365

      I'll attach a patch in a moment.

        Gliffy Diagrams

          Activity

          Hide
          davosmith Davo Smith added a comment -

          Patch added - note this builds on my patch for MDL-42352

          Show
          davosmith Davo Smith added a comment - Patch added - note this builds on my patch for MDL-42352
          Hide
          damyon Damyon Wiese added a comment -

          Thanks again Davo. Looks good to me (I added testing instructions).

          [Y] Syntax
          [Y] Whitespace
          [-] Output
          [-] Language
          [-] Databases
          [Y (I added them)] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [Y] Git
          [-] Third party code
          [Y] Sanity check

          Note to integrator - there are undoubtedly going to be conflicts in the shifted files with this, or any of the other editpdf issues - please just reshift them.

          Show
          damyon Damyon Wiese added a comment - Thanks again Davo. Looks good to me (I added testing instructions). [Y] Syntax [Y] Whitespace [-] Output [-] Language [-] Databases [Y (I added them)] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check Note to integrator - there are undoubtedly going to be conflicts in the shifted files with this, or any of the other editpdf issues - please just reshift them.
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated, thanks Davo

          Show
          poltawski Dan Poltawski added a comment - Integrated, thanks Davo
          Hide
          abgreeve Adrian Greeve added a comment -

          Tested on the master integration branch.
          When clicking on the comment menu, the comment does not disappear.
          Test Passed.

          Show
          abgreeve Adrian Greeve added a comment - Tested on the master integration branch. When clicking on the comment menu, the comment does not disappear. Test Passed.
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

          Show
          poltawski Dan Poltawski added a comment - Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13