Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42487

User's profile information resides outside of the theme's container for brick and leatherbound

    Details

    • Testing Instructions:
      Hide

      Purge theme caches
      Switch theme to Leatherbound or Brick
      View a User profile.
      The user details will appear within the 2nd div right of the profile image.

      Show
      Purge theme caches Switch theme to Leatherbound or Brick View a User profile. The user details will appear within the 2nd div right of the profile image.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      mdl42487-master

      Description

      User's profile information resides outside of the theme's container for brick and leatherbound related to the use of 'dl' compared to Moodle 2.2

        Gliffy Diagrams

          Activity

          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Tim,

          Thank you for creating patch for this issue.

          Some feedback for the patch, we are eliminating the use of "!important" for css.

          The issue also occurs in other theme that's using canvas as based theme. So perhaps the fix should be done in canvas theme.

          Please update the patch and re-send it for peer-review once it is ready.

          Thanks
          Rosie

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Tim, Thank you for creating patch for this issue. Some feedback for the patch, we are eliminating the use of "!important" for css. The issue also occurs in other theme that's using canvas as based theme. So perhaps the fix should be done in canvas theme. Please update the patch and re-send it for peer-review once it is ready. Thanks Rosie
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for working on this, Tim.

          As Rosie says, please put this up for peer review when it's ready.

          Show
          salvetore Michael de Raadt added a comment - Thanks for working on this, Tim. As Rosie says, please put this up for peer review when it's ready.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Thanks Tim for bringing this problem to the fore, however I have found that if you remove all the CSS pertaining to the User Profile in Canvas theme from line 233 to line 310 it works perfectly, as the CSS comes directly from Base theme. The same is true for all RTL languages too, which is something that we have to take into account.

          Show
          lazydaisy Mary Evans added a comment - - edited Thanks Tim for bringing this problem to the fore, however I have found that if you remove all the CSS pertaining to the User Profile in Canvas theme from line 233 to line 310 it works perfectly, as the CSS comes directly from Base theme. The same is true for all RTL languages too, which is something that we have to take into account.
          Hide
          tlock Tim Lock added a comment -

          Updated based on PR in canvas theme.

          Show
          tlock Tim Lock added a comment - Updated based on PR in canvas theme.
          Hide
          lazydaisy Mary Evans added a comment -

          Seems OK to me.

          Show
          lazydaisy Mary Evans added a comment - Seems OK to me.
          Hide
          lazydaisy Mary Evans added a comment -

          This works OK so submitting for integration review.

          Show
          lazydaisy Mary Evans added a comment - This works OK so submitting for integration review.
          Hide
          poltawski Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          marina Marina Glancy added a comment -

          Thanks Tim, great fix.

          List of all affected themes:

          arialist
          binarius
          boxxie
          brick
          formal_white
          formfactor
          fusion
          leatherbound
          magazine
          nimble
          nonzero
          overlay
          serenity
          sky_high
          splash

          Show
          marina Marina Glancy added a comment - Thanks Tim, great fix. List of all affected themes: arialist binarius boxxie brick formal_white formfactor fusion leatherbound magazine nimble nonzero overlay serenity sky_high splash
          Hide
          marina Marina Glancy added a comment -

          forgot to say, integrated in 2.5, 2.6 and master.

          Show
          marina Marina Glancy added a comment - forgot to say, integrated in 2.5, 2.6 and master.
          Hide
          salvetore Michael de Raadt added a comment -

          Test result: Success!

          Tested in 2.5, 2.6 and master. The description appeared in a second div with class "descriptionbox".

          Thanks for your efforts.

          Show
          salvetore Michael de Raadt added a comment - Test result: Success! Tested in 2.5, 2.6 and master. The description appeared in a second div with class "descriptionbox". Thanks for your efforts.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks for the code, its now upstream!

          Heres a fun trick to try in the spirit of Friday the 13th.
          I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks for the code, its now upstream! Heres a fun trick to try in the spirit of Friday the 13th. I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14