Moodle
  1. Moodle
  2. MDL-42489

Abstract class instantiated in backup cron helper

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Backup
    • Labels:
      None
    • Rank:
      54291

      Description

      we have

      throw new backup_exception('backup_automated_already_running');
      

      in backup_cron_helper.class.php
      backup_exception is an abstract class and cannot be used this way

        Issue Links

          Activity

          Hide
          Mark Nelson added a comment -

          Patch looks perfect.

          Submitting to integration.

          Show
          Mark Nelson added a comment - Patch looks perfect. Submitting to integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Damyon Wiese added a comment -

          Thanks Ankit.

          Integrated to 24, 25 and master. I'll pass the testing for this too.

          Show
          Damyon Wiese added a comment - Thanks Ankit. Integrated to 24, 25 and master. I'll pass the testing for this too.
          Hide
          Damyon Wiese added a comment -

          Trivial change - code review is sufficient.

          Show
          Damyon Wiese added a comment - Trivial change - code review is sufficient.
          Hide
          Damyon Wiese added a comment -

          Here lies 52 bugs.
          All fixed or swept under a rug.
          If they come back one day,
          To our dismay,
          We all will feel quite un-smug.

          Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

          Show
          Damyon Wiese added a comment - Here lies 52 bugs. All fixed or swept under a rug. If they come back one day, To our dismay, We all will feel quite un-smug. Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: