Moodle
  1. Moodle
  2. MDL-42505

Feedback - Incorrect use of fieldset tags and implementation of label for dropdown controls

    Details

    • Testing Instructions:
      Hide

      As a logged-in Site Administrator:

      1. Enable the feedback module by clicking Home > Site Administration > Plugins -> Activity modules -> Manage activities
      2. Go to a course, add a Feedback activity
      3. View the activity
      4. Add a "Multiple choice - single answer" type question.
      5. Insert Radio Buttons in the label and the following values (1 per line): Red, Yellow, Green, Blue.
      6. Add a "Multiple choice - multiple answers" type question.
      7. Insert Checkboxes in the label and the following values (1 per line): Red, Yellow, Green, Blue.
      8. Add a "Multiple choice - single answer allowed (dropdownlist)" question.
      9. Insert Dropdown List in the label and the following values (1 per line): Red, Yellow, Green, Blue.
      10. Add a "Multiple choice (rated) - single answer" type question.
      11. Insert Rated Radio Buttons in the label and the following values (1 per line): 10/Red, 20/Yellow, 30/Green, 40/Blue
      12. Add a "Multiple choice (rated) - single answer allowed (dropdownlist)" question.
      13. Insert Rated Dropdown List in the label and the following values (1 per line): 10/Red, 20/Yellow, 30/Green, 40/Blue
      14. Click the Overview tab and then the "Answer the question..." link to begin the feedback. This will now test the Complete version of the code changes.
      15. View the page source code.
      16. Test for A: Locate the form. Notice that it is no longer wrapped in a <fieldset> tag.
      17. Test for A: Locate the Cancel button. Notice that there is no longer any <fieldset> tags around it.
      18. Test for B: Locate the Checkboxes input fields and notice that they are now grouped in a fieldset tag.
      19. Test for B: Locate the Radio Buttons input fields and notice that they are grouped in a fieldset tag.
      20. Test for B: Locate the Rated Radio Buttons input fields and notice that they are now grouped in a fieldset tag.
      21. Test for C: Locate the Dropdown List select field and notice that it is now in a DIV instead of a UL and LI tag.
      22. Test for D: Notice that Dropdown List no longer appear in duplicate in the source code. You can also see this in the rendered page if you disable all CSS styles.
      23. Test for C: Locate the Rated Dropdown List select field and notice that it is now in a DIV instead of a UL and LI tag.
      24. Test for D: Notice that Rated Dropdown List no longer appear in duplicate in the source code. You can also see this in the rendered page if you disable all CSS styles.
      25. Click your browsers back button and then the Edit questions tab at the top of the page. This will now test the Preview version of the code changes.
      26. Go back to step 15 and repeat above.
      Show
      As a logged-in Site Administrator: Enable the feedback module by clicking Home > Site Administration > Plugins -> Activity modules -> Manage activities Go to a course, add a Feedback activity View the activity Add a "Multiple choice - single answer" type question. Insert Radio Buttons in the label and the following values (1 per line): Red, Yellow, Green, Blue. Add a "Multiple choice - multiple answers" type question. Insert Checkboxes in the label and the following values (1 per line): Red, Yellow, Green, Blue. Add a "Multiple choice - single answer allowed (dropdownlist)" question. Insert Dropdown List in the label and the following values (1 per line): Red, Yellow, Green, Blue. Add a "Multiple choice (rated) - single answer" type question. Insert Rated Radio Buttons in the label and the following values (1 per line): 10/Red, 20/Yellow, 30/Green, 40/Blue Add a "Multiple choice (rated) - single answer allowed (dropdownlist)" question. Insert Rated Dropdown List in the label and the following values (1 per line): 10/Red, 20/Yellow, 30/Green, 40/Blue Click the Overview tab and then the "Answer the question..." link to begin the feedback. This will now test the Complete version of the code changes. View the page source code. Test for A: Locate the form. Notice that it is no longer wrapped in a <fieldset> tag. Test for A: Locate the Cancel button. Notice that there is no longer any <fieldset> tags around it. Test for B: Locate the Checkboxes input fields and notice that they are now grouped in a fieldset tag. Test for B: Locate the Radio Buttons input fields and notice that they are grouped in a fieldset tag. Test for B: Locate the Rated Radio Buttons input fields and notice that they are now grouped in a fieldset tag. Test for C: Locate the Dropdown List select field and notice that it is now in a DIV instead of a UL and LI tag. Test for D: Notice that Dropdown List no longer appear in duplicate in the source code. You can also see this in the rendered page if you disable all CSS styles. Test for C: Locate the Rated Dropdown List select field and notice that it is now in a DIV instead of a UL and LI tag. Test for D: Notice that Rated Dropdown List no longer appear in duplicate in the source code. You can also see this in the rendered page if you disable all CSS styles. Click your browsers back button and then the Edit questions tab at the top of the page. This will now test the Preview version of the code changes. Go back to step 15 and repeat above.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42505-Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button

      Description

      A. Inappropriate usage of fieldset tags

      Affects: Whole form and Cancel button

      Issue: When displaying a feedback form (both preview and complete view), the whole form as well as the Cancel button are wrapped in a fieldset tag. While all the fields in a form are related in that it one whole form, the intent of the fieldset tag is to group sets of related fields. For example, the a set of radio buttons or checkboxes, or the input fields which make up an address.

      The current implementation results in failure of WCAG 2.0 Criterion 1.3.1 (1:Perceivable, 3:Adaptable, 1:Info and Relationships) as tested using the following technique: H71: Failure of Success Criterion 1.3.1 due to using structural markup in a way that does not represent relationships in the content. For more information, see http://www.w3.org/TR/WCAG20-TECHS/H71.html#H71-tests.

      Recommendation: Remove the <fieldset>/</fieldset> tags around the form and Cancel button.

      Files that would need to be modified:

      • /mod/feedback/complete.php
      • /mod/feedback/complete_guest.php

      B. Missing fieldset tags

      Affected question types:

      • Multiple choice, multiple answers (checkboxes)
      • Multiple choice (rated), multiple answers (checkboxes)
      • Multiple choice, single answer allowed (Radio Buttons)
      • Multiple choice (rated), single answer allowed (Radio Buttons)

      Issue: Related groups of controls are not grouped in a fieldset tags

      The current implementation results in failure of WCAG 2.0 Criterion 1.3.1 (1:Perceivable, 3:Adaptable, 1:Info and Relationships) as tested using the following technique: H71: Providing a description for groups of form controls using fieldset and legend elements. For more information, see http://www.w3.org/TR/2013/NOTE-WCAG20-TECHS-20130905/H71#H71-tests.

      Recommendation: Wrap groups of related radio buttons and groups of related fieldset controls in fieldset tags.

      Files that would need to be modified:

      • /mod/feedback/item.multichoce/lib.php
      • /mod/feedback/item.multichocerated/lib.php

      C. Inappropriate use of unordered list

      The following files would need to be modified:

      • Multiple choice, single answer allowed (dropdownlist)
      • Multiple choice (rated), single answer allowed (dropdownlist)

      Issue: When displaying a dropdown list in a form, each set of label/dropdown list control are wrapped in a single item unordered list. This is inappropriate use of unordered lists because you will never have multiple dropdown lists in a single question.

      This implementation results in failure of WCAG 2.0 Criterion 1.3.1 (1:Perceivable, 3:Adaptable, 1:Info and Relationships) as tested using the following technique: F43: Failure of Success Criterion 1.3.1 due to using structural markup in a way that does not represent relationships in the content. For more information, see Failure Technique #4 at http://www.w3.org/TR/WCAG-TECHS/F43.html#F43-tests.

      Recommendation: Remove the <ul> tags and replace the <li> tags with div tags so as to maintain the developers ability to apply CSS styles.

      Files that would need to be modified:

      • /mod/feedback/item.multichoce/lib.php
      • /mod/feedback/item.multichocerated/lib.php

      D. Duplicate hidden label field

      Affected questions types:

      • Multiple choice, single answer allowed (dropdownlist)
      • Multiple choice (rated), single answer allowed (dropdownlist)

      Issue: There is a hidden label for dropdown lists. This is an issue for users who turn off styles and may affect users of screen readers.

      This implementation results in failure of WCAG 2.0 Criterion 1.3.1 (1:Perceivable, 3:Adaptable, 1:Info and Relationships) as tested using the following technique: F43: Failure of Success Criterion 1.3.1 due to using structural markup in a way that does not represent relationships in the content. For more information, see Failure Technique #4 at http://www.w3.org/TR/WCAG-TECHS/F43.html#F43-tests.

      Recommendation: Remove the hidden copy of the label as it doesn't appear to serve any purpose.

      Files that would need to be modified:

      • /mod/feedback/item.multichoce/lib.php
      • /mod/feedback/item.multichocerated/lib.php

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for working on this, Michael.

          When you think it is ready, you can push it to peer review. Hopefully Andreas can review it then.

          Show
          Michael de Raadt added a comment - Thanks for working on this, Michael. When you think it is ready, you can push it to peer review. Hopefully Andreas can review it then.
          Hide
          Michael Milette added a comment -

          It's ready!

          Show
          Michael Milette added a comment - It's ready!
          Hide
          Michael Milette added a comment -

          Attached a test feedback form. Hope it helps with testing process.

          Show
          Michael Milette added a comment - Attached a test feedback form. Hope it helps with testing process.
          Hide
          Michael Milette added a comment -

          Is there any chance that this might make it into the 2.6.1 release?

          Show
          Michael Milette added a comment - Is there any chance that this might make it into the 2.6.1 release?
          Hide
          Michael Milette added a comment - - edited

          Hi Andreas,

          Is there anything more I need to do to get this one moving forward?

          Best regards,

          Michael

          Show
          Michael Milette added a comment - - edited Hi Andreas, Is there anything more I need to do to get this one moving forward? Best regards, Michael
          Hide
          CiBoT added a comment -

          Results for MDL-42505

          • Error: the repository field is empty. Nothing was checked.
          Show
          CiBoT added a comment - Results for MDL-42505 Error: the repository field is empty. Nothing was checked.
          Hide
          Michael Milette added a comment -

          Hi CiBoT,

          What does this error mean? Do I need to do anything? I have submitted several patches in the past exactly the same way but haven't come across this.

          I Googled the error but all that came up was the same comment you added to several tracker issues (mine and others) today.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi CiBoT, What does this error mean? Do I need to do anything? I have submitted several patches in the past exactly the same way but haven't come across this. I Googled the error but all that came up was the same comment you added to several tracker issues (mine and others) today. Best regards, Michael
          Hide
          Michael Milette added a comment -

          I just added the Pull from Repository URL.

          Please let me know if there is any other required information missing.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - I just added the Pull from Repository URL. Please let me know if there is any other required information missing. Best regards, Michael
          Hide
          Michael Milette added a comment -

          Hi Michael,

          I noticed that Andreas is not a participant of this Tracker issue. Just in case he missed it (I assume he is probably very busy), is there any chance you might be able to share a friendly reminder with him that this issue as well as MDL-42462 have been pending since October 2013? I would be very grateful for any assistance you can offer in moving these issue forward.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi Michael, I noticed that Andreas is not a participant of this Tracker issue. Just in case he missed it (I assume he is probably very busy), is there any chance you might be able to share a friendly reminder with him that this issue as well as MDL-42462 have been pending since October 2013? I would be very grateful for any assistance you can offer in moving these issue forward. Best regards, Michael
          Hide
          Michael de Raadt added a comment -

          Thanks for following up on this. I've unassigned Andreas as peer reviewer to allow other people to take on the peer review. If Andreas comes along soon he can still review it.

          Show
          Michael de Raadt added a comment - Thanks for following up on this. I've unassigned Andreas as peer reviewer to allow other people to take on the peer review. If Andreas comes along soon he can still review it.
          Hide
          Rossiani Wijaya added a comment -

          Hi Michael,

          Thank you for creating patch for this issue.

          Just some minor feedback on the patch:

          if ($info->subtype == 'r' || $info->subtype == 'c') 

          It would be helpful if you could add a comment on what is subtype 'c' or 'r' representing.

          Could you also backport this patch for 2.5 and 2.6.

          Thanks
          Rosie

          [y] Syntax
          [y] Whitespace
          [y] Output
          [-] Language
          [-] Databases
          [y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [y] Git
          [-] Third party code
          [y] Sanity check

          Show
          Rossiani Wijaya added a comment - Hi Michael, Thank you for creating patch for this issue. Just some minor feedback on the patch: if ($info->subtype == 'r' || $info->subtype == 'c') It would be helpful if you could add a comment on what is subtype 'c' or 'r' representing. Could you also backport this patch for 2.5 and 2.6. Thanks Rosie [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [-] Third party code [y] Sanity check
          Hide
          Michael Milette added a comment -

          Hi Rosie,

          Sorry for the delay in getting back to you. I didn't have a local copy of the patch anymore and had to recreate it after it was lost back in December after an unsuccessful attempt to rebase.

          Anyway, I've updated the Pull Master Diff URL and the Pull Master Branch fields with updated information which links to updated code which includes the additional comments you requested.

          As for the backports, I am not current setup for that. I use Git GUI but it only lists a Master branch (and my patches of course). Could you provide me with preferably quick and easy instructions on how to set up the backporting for the 2.5 and 2.6 branches in Git Gui?

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi Rosie, Sorry for the delay in getting back to you. I didn't have a local copy of the patch anymore and had to recreate it after it was lost back in December after an unsuccessful attempt to rebase. Anyway, I've updated the Pull Master Diff URL and the Pull Master Branch fields with updated information which links to updated code which includes the additional comments you requested. As for the backports, I am not current setup for that. I use Git GUI but it only lists a Master branch (and my patches of course). Could you provide me with preferably quick and easy instructions on how to set up the backporting for the 2.5 and 2.6 branches in Git Gui? Best regards, Michael
          Hide
          Rossiani Wijaya added a comment -

          Hi Michael,

          I'm not familiar with Git Gui to backport the patch. However I created the patch for 2.5 and 2.6.

          Please take a look the backported patch and let me know if you need me to push it for integration review.

          Show
          Rossiani Wijaya added a comment - Hi Michael, I'm not familiar with Git Gui to backport the patch. However I created the patch for 2.5 and 2.6. Please take a look the backported patch and let me know if you need me to push it for integration review.
          Hide
          Michael Milette added a comment -

          Hi Rosie,

          Thank you for creating the other branches. I toke a look the backported patch and they all look good to me. Please push it for integration review.

          Show
          Michael Milette added a comment - Hi Rosie, Thank you for creating the other branches. I toke a look the backported patch and they all look good to me. Please push it for integration review.
          Hide
          CiBoT added a comment -

          Results for MDL-42505

          • Remote repository: git://github.com/rwijaya/moodle.git
          Show
          CiBoT added a comment - Results for MDL-42505 Remote repository: git://github.com/rwijaya/moodle.git Remote branch MDL-42505 _m25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/673 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/673/artifact/work/smurf.html Remote branch MDL-42505 _m26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/674 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/674/artifact/work/smurf.html Remote branch MDL-42505 -Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/675 Error: Unable to fetch information from MDL-42505 -Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button branch at git://github.com/rwijaya/moodle.git.
          Hide
          Rossiani Wijaya added a comment -

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Michael Milette added a comment -

          Hi Eloy,

          Thanks for the suggestion. I followed the instructions on the Git for Developers page, re-syncing my repository and rebasing the branches. Hopefully it worked. Let me know if anything more needs to be done.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi Eloy, Thanks for the suggestion. I followed the instructions on the Git for Developers page, re-syncing my repository and rebasing the branches. Hopefully it worked. Let me know if anything more needs to be done. Best regards, Michael
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Sam Hemelryk added a comment -

          Hi Michael and Rossiani,

          I'm send this back this week just for a couple of things to be touched up.

          1. There are styles within mod/feedback/styles.css that point explicitly to li.feedback_item_select_* (now div) these either need updating or removal.
          2. There are whitespace issues in mod/feedback/item/multichoice/lib.php (three lines with trailing whitespace) Usually I would fix this up for you during integration, however as I'm send it back could you please fix it up at the same time.

          Sorry for any inconvenience

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Hi Michael and Rossiani, I'm send this back this week just for a couple of things to be touched up. There are styles within mod/feedback/styles.css that point explicitly to li.feedback_item_select_* (now div) these either need updating or removal. There are whitespace issues in mod/feedback/item/multichoice/lib.php (three lines with trailing whitespace) Usually I would fix this up for you during integration, however as I'm send it back could you please fix it up at the same time. Sorry for any inconvenience Many thanks Sam
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Michael Milette added a comment -

          Hi Sam,

          Thank you for your feedback. I have addressed both of the issues you mentioned and updated the Pull Master Diff URL with a new link.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi Sam, Thank you for your feedback. I have addressed both of the issues you mentioned and updated the Pull Master Diff URL with a new link. Best regards, Michael
          Hide
          CiBoT added a comment -

          Results for MDL-42505

          • Remote repository: git://github.com/rwijaya/moodle.git
          Show
          CiBoT added a comment - Results for MDL-42505 Remote repository: git://github.com/rwijaya/moodle.git Remote branch MDL-42505 _m25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/891 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/891/artifact/work/smurf.html Remote branch MDL-42505 _m26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/892 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/892/artifact/work/smurf.html Remote branch MDL-42505 -Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/893 Error: Unable to fetch information from MDL-42505 -Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button branch at git://github.com/rwijaya/moodle.git.
          Hide
          Michael Milette added a comment -

          Do I need to do something about the error?

          Show
          Michael Milette added a comment - Do I need to do something about the error?
          Hide
          Michael Milette added a comment -

          Please let me know if there is anything more I can do to move this issue forward.

          Show
          Michael Milette added a comment - Please let me know if there is anything more I can do to move this issue forward.
          Hide
          Sam Hemelryk added a comment -

          Hi Michael, you don't have to worry about the error there, its because some branches are in your repository and some in Rossi's. Nothing the integrator won't be able to deal with

          I've moved this back up for integration review now so that it will be considered again next week.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Michael, you don't have to worry about the error there, its because some branches are in your repository and some in Rossi's. Nothing the integrator won't be able to deal with I've moved this back up for integration review now so that it will be considered again next week. Cheers Sam
          Hide
          Michael Milette added a comment -

          Thank you Sam!

          Show
          Michael Milette added a comment - Thank you Sam!
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Marina Glancy added a comment -

          Thanks Michael, integrated in 2.5, 2.6 and master

          I've cherry-picked the commit from master into stables. Rossi's branches do not include the last changes.

          Michael, please note that we have some coding style standards in Moodle that includes an interesting rule that comments must start with capital letter and end with a fullstop. I did not reject your commit because of not following this but would be nice if you consider it for the next issues. Thanks again for contributing to Moodle

          Show
          Marina Glancy added a comment - Thanks Michael, integrated in 2.5, 2.6 and master I've cherry-picked the commit from master into stables. Rossi's branches do not include the last changes. Michael, please note that we have some coding style standards in Moodle that includes an interesting rule that comments must start with capital letter and end with a fullstop. I did not reject your commit because of not following this but would be nice if you consider it for the next issues. Thanks again for contributing to Moodle
          Hide
          Michael Milette added a comment -

          Hi Marina,

          Thanks for fixing that up. I became aware of that particular coding style about a week ago when CiBoT seemed to start reporting it and have been applying that standard since in all my work and will continue to do so. Sorry for the inconvenience.

          On a side note, I agree with this standard for the most part. The only issue I have with it is that it won't let you start a comment with a $variablename. For example, I have to say:

          // The $variablename variable contains the number of times the user logged-in.

          instead of just...

          // $variablename contains the number of times the user logged-in.

          Anyway, I will comply with the standard. Just thought I'd share this in case there is ever an opportunity to make this small change in the standard.

          Thank you again for your assistance Marina. I really appreciate you not holding this fix up.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Hi Marina, Thanks for fixing that up. I became aware of that particular coding style about a week ago when CiBoT seemed to start reporting it and have been applying that standard since in all my work and will continue to do so. Sorry for the inconvenience. On a side note, I agree with this standard for the most part. The only issue I have with it is that it won't let you start a comment with a $variablename. For example, I have to say: // The $variablename variable contains the number of times the user logged-in. instead of just... // $variablename contains the number of times the user logged-in. Anyway, I will comply with the standard. Just thought I'd share this in case there is ever an opportunity to make this small change in the standard. Thank you again for your assistance Marina. I really appreciate you not holding this fix up. Best regards, Michael
          Hide
          Marina Glancy added a comment -

          Thanks to you Michael for working on it.
          Another coding standard error that I noticed already after integration (because the automatic checker spammed me with error messages) is that you had tabs in the new lines in styles.css. Tabs are no longer allowed in Moodle (4 spaces are used for indentation) but we did not fix all existing ones yet. So when you copy-pasted the line in styles.css you have increased the number of tabs in the file. I pushed an additional commit to fix them.

          Show
          Marina Glancy added a comment - Thanks to you Michael for working on it. Another coding standard error that I noticed already after integration (because the automatic checker spammed me with error messages) is that you had tabs in the new lines in styles.css. Tabs are no longer allowed in Moodle (4 spaces are used for indentation) but we did not fix all existing ones yet. So when you copy-pasted the line in styles.css you have increased the number of tabs in the file. I pushed an additional commit to fix them.
          Hide
          Dan Poltawski added a comment -

          Thanks Michael, looks good.

          Show
          Dan Poltawski added a comment - Thanks Michael, looks good.
          Hide
          Michael Milette added a comment - - edited

          Marina - I started replacing tabs with spaces around mid-December. Unfortunately this patch has was done before that. There shouldn't be anymore tabs in any of my recent changes (my editor is now configured never to insert tabs). Thanks for mentioning it though... a great reminder. And thanks for the extra fix.

          Dan - Thank you for testing. Do I need to do anything to move this on to the next step in the process?

          Best regards,

          Michael

          Show
          Michael Milette added a comment - - edited Marina - I started replacing tabs with spaces around mid-December. Unfortunately this patch has was done before that. There shouldn't be anymore tabs in any of my recent changes (my editor is now configured never to insert tabs). Thanks for mentioning it though... a great reminder. And thanks for the extra fix. Dan - Thank you for testing. Do I need to do anything to move this on to the next step in the process? Best regards, Michael
          Hide
          Dan Poltawski added a comment -

          Michael: nope, it looks like this will be included in this weeks Moodle release

          Show
          Dan Poltawski added a comment - Michael: nope, it looks like this will be included in this weeks Moodle release
          Hide
          Michael Milette added a comment -

          Thanks Dan.

          I want to acknowledge and thank everyone who participated in integrating this patch into Moodle including Dan Poltawski, Marina Glancy, Sam Hemelryk, Eloy Lafuente, Rossiani Wijaya and Michael de Raadt. I really appreciate all the time and effort you've contributed.

          Best regards,

          Michael

          Show
          Michael Milette added a comment - Thanks Dan. I want to acknowledge and thank everyone who participated in integrating this patch into Moodle including Dan Poltawski, Marina Glancy, Sam Hemelryk, Eloy Lafuente, Rossiani Wijaya and Michael de Raadt. I really appreciate all the time and effort you've contributed. Best regards, Michael
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fetch your remotes, prune them,
          clean your integrated branches and say "Ahem".

          Rebase your ongoing stuff, keep conflicts away
          don't forget to test the code and we'll love you again.

          Thanks, closing!

          Show
          Eloy Lafuente (stronk7) added a comment - Fetch your remotes, prune them, clean your integrated branches and say "Ahem". Rebase your ongoing stuff, keep conflicts away don't forget to test the code and we'll love you again. Thanks, closing!
          Hide
          Michael de Raadt added a comment -

          Nice work, Michael.

          Show
          Michael de Raadt added a comment - Nice work, Michael.
          Hide
          Michael Milette added a comment -

          Thank you Michael!

          Show
          Michael Milette added a comment - Thank you Michael!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: