Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42511

Debugging from set_callback_options() with incorrect params

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Portfolio
    • Labels:
      None
    • Testing Instructions:
      Hide

      I haven't found an easy way to test this without hacking around

      1. Enable portfolios and some portfolios plugins
      2. Edit the file mod/forum/lib.php:3426 (function forum_print_post) and change the 3rd argument of $button->set_callback_options to: 

        'mod/forum/locallib.php'
        		 
        So it should look like this:
        		 
        $button->set_callback_options('forum_portfolio_caller', array('postid' => $post->id), 'mod/forum/locallib.php');

      3. Post to a forum
      4. View the discussion including your post
      5. Export that one post to a portfolio
      6. Make sure you don't see any warning about a deprecated function

      Note: There is still the debugging 'The third parameter sent to the function set_callback_options should be the component name, not a file path, please update this.'

      Show
      I haven't found an easy way to test this without hacking around Enable portfolios and some portfolios plugins Edit the file mod/forum/lib.php:3426 (function forum_print_post) and change the 3rd argument of $button->set_callback_options to: 'mod/forum/locallib.php' So it should look like this: $button->set_callback_options('forum_portfolio_caller', array('postid' => $post->id), 'mod/forum/locallib.php'); Post to a forum View the discussion including your post Export that one post to a portfolio Make sure you don't see any warning about a deprecated function Note: There is still the debugging 'The third parameter sent to the function set_callback_options should be the component name, not a file path, please update this.'
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42511-master
    • Pull Master Diff URL:

      Attachments

        Issue Links

        blocks

        Functional Test - A test of a single Moodle feature MDLQA-5936 CLONE - The cron can be manually run from a web browser

        • Minor - Minor loss of function where workaround is possible
        • Passed
        has a non-specific relationship to

        Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-2572 Inspect content of portfolio_tempdata on QA

        • Low - Cosmetic problems, nice-to-have features
        • Closed

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Petr Skoda Petr Skoda
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Ankit Agarwal Ankit Agarwal
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/13