Moodle
  1. Moodle
  2. MDL-42517

Eventslib test should use assertDebuggingCalled()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Unit tests
    • Labels:

      Description

      There was a change made to the eventslib test as part of MDL-41900 to prevent the new debugging call making noise during the test. It would be better if this were to use the assertDebuggingCalled() method of advanced_testcase rather than disabling debugging, as this would test the MDL-41900 change.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael Aherne added a comment -

            Added a patch for this.

            Show
            Michael Aherne added a comment - Added a patch for this.
            Hide
            Petr Skoda added a comment -

            Thanks a lot, submitting for integration.

            Show
            Petr Skoda added a comment - Thanks a lot, submitting for integration.
            Hide
            Michael Aherne added a comment -

            I have updated this patch to remove the extraneous comments since the peer review. Does it need to be peer reviewed again?

            Show
            Michael Aherne added a comment - I have updated this patch to remove the extraneous comments since the peer review. Does it need to be peer reviewed again?
            Hide
            Petr Skoda added a comment -

            no problem, thanks!

            Show
            Petr Skoda added a comment - no problem, thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Thanks Michael, integrated to master, 25 and 24.

            Show
            Dan Poltawski added a comment - Thanks Michael, integrated to master, 25 and 24.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Passing, 24, 25 and master pass.

            Show
            Eloy Lafuente (stronk7) added a comment - Passing, 24, 25 and master pass.
            Hide
            Dan Poltawski added a comment -

            Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

            Show
            Dan Poltawski added a comment - Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: