Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42530

yui_combo should send 404s often

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • 2.6
    • None
    • HTML and CSS, JavaScript, Themes
    • None
    • MOODLE_26_STABLE

    Description

      While reviewing MDL-41966, I detected (by forcing some invalid requests), that there are a bunch of situations where an textual error message is sent back to browser, surely with a wrong mime type and worse, with an "all-ok" 200.

      This is about to review those places in yui_combo (especially all the "continue" statements there, or any other adding "error/wrong/not found" text to the $content, in order to 1) raise some "problem flag" and 2) based on that flag, return a 404 instead of current 200.

      For your consideration, not critical but 200s should be sent for those unsatisfactory responses, IMO.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              stronk7 Eloy Lafuente (stronk7)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: