Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42531

Cancel buttons on batch marker allocate and workflow state pages still save changes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Check 1 - cancel should cancel

      (Make sure you have some teachers and students enrolled in the course before you begin).

      1. In an assignment activity with marking workflow enabled, view/grade all submissions and tick one or more submissions that have 'Not marked' state.
      2. From the 'With selected' options, choose 'Set marking workflow state' and click 'Go'. Accept the confirmation dialogue.
      3. Click the 'Cancel' button.
      4. Observe that the submission state has remained at 'Not marked'.
      1. In an assignment activity with marking allocation enabled, view/grade all submissions and tick one or more submissions that have no marker assigned.
      2. From the 'With selected' options, choose 'Set allocated marker' and click 'Go'. Accept the confirmation dialogue.
      3. Click the 'Cancel' button.
      4. Observe that the submission marker has remained unset.

      Check 2 - check that non-cancel code paths still work

      Check 1 - cancel should cancel

      1. In an assignment activity with marking workflow enabled, view/grade all submissions and tick one or more submissions that have 'Not marked' state.
      2. From the 'With selected' options, choose 'Set marking workflow state' and click 'Go'. Accept the confirmation dialogue.
      3. Change the state and click "Save changes"
      4. Observe that the submission state has updated correctly
      1. In an assignment activity with marking allocation enabled, view/grade all submissions and tick one or more submissions that have no marker assigned and a work state not in this list (ready for review, in review, ready for release, released)
      2. From the 'With selected' options, choose 'Set allocated marker' and click 'Go'. Accept the confirmation dialogue.
      3. Change the marker and click "Save changes"
      4. Observe that the submission marker has changed
      Show
      Check 1 - cancel should cancel (Make sure you have some teachers and students enrolled in the course before you begin). In an assignment activity with marking workflow enabled, view/grade all submissions and tick one or more submissions that have 'Not marked' state. From the 'With selected' options, choose 'Set marking workflow state' and click 'Go'. Accept the confirmation dialogue. Click the 'Cancel' button. Observe that the submission state has remained at 'Not marked'. In an assignment activity with marking allocation enabled, view/grade all submissions and tick one or more submissions that have no marker assigned. From the 'With selected' options, choose 'Set allocated marker' and click 'Go'. Accept the confirmation dialogue. Click the 'Cancel' button. Observe that the submission marker has remained unset. Check 2 - check that non-cancel code paths still work Check 1 - cancel should cancel In an assignment activity with marking workflow enabled, view/grade all submissions and tick one or more submissions that have 'Not marked' state. From the 'With selected' options, choose 'Set marking workflow state' and click 'Go'. Accept the confirmation dialogue. Change the state and click "Save changes" Observe that the submission state has updated correctly In an assignment activity with marking allocation enabled, view/grade all submissions and tick one or more submissions that have no marker assigned and a work state not in this list (ready for review, in review, ready for release, released) From the 'With selected' options, choose 'Set allocated marker' and click 'Go'. Accept the confirmation dialogue. Change the marker and click "Save changes" Observe that the submission marker has changed
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42531-alt

      Description

      There is no code to handle the user clicking 'Cancel' on the 'Set allocated marker' and 'Set marking workflow state' pages. As a result, unintended workflow state and marker changes are possible.

        Attachments

          Activity

            People

            Assignee:
            jonof Jonathon Fowler
            Reporter:
            jonof Jonathon Fowler
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Damyon Wiese
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14