[MDL-42540] SetType() warnings in quiz - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5
Fix Version/s: 2.4.8, 2.5.4, 2.6
Component/s: Quiz
Labels:
- triaged

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-42540~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-42540
Testing Instructions:

Hide

0. You need a quiz with some student attempts.

1. Go to Results -> Manual grading. If necessary click 'Also show questions that have been graded automatically'.

2. Click on one of the links to grade something.

3. In the Options form at the top of the page, change something (e.g. Sort order) and click Change options.

4. Verify that there are no Notices about SetType.

Show
0. You need a quiz with some student attempts. 1. Go to Results -> Manual grading. If necessary click 'Also show questions that have been graded automatically'. 2. Click on one of the links to grade something. 3. In the Options form at the top of the page, change something (e.g. Sort order) and click Change options. 4. Verify that there are no Notices about SetType.

Description

Follow these steps:-
Make sure you have a quiz with atleast one essay questions and a few attempts.
Go to Quiz > Results > Manual grading
Click on "Grade" under "To grade"
Make sure no warning or notices is generated

Following notices are generated in the process

Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.

line 1336 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform()

line 363 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct()

line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface()

line 100 of /mod/quiz/report.php: call to quiz_grading_report->display()

Did you remember to call setType() for 'mode'? Defaulting to PARAM_RAW cleaning.

line 1336 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform()

line 363 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct()

line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface()

line 100 of /mod/quiz/report.php: call to quiz_grading_report->display()

Did you remember to call setType() for 'slot'? Defaulting to PARAM_RAW cleaning.

line 1336 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform()

line 363 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct()

line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface()

line 100 of /mod/quiz/report.php: call to quiz_grading_report->display()

Did you remember to call setType() for 'qid'? Defaulting to PARAM_RAW cleaning.

line 1336 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform()

line 363 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct()

line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface()

line 100 of /mod/quiz/report.php: call to quiz_grading_report->display()

Did you remember to call setType() for 'page'? Defaulting to PARAM_RAW cleaning.

line 1336 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform()

line 363 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct()

line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface()

line 100 of /mod/quiz/report.php: call to quiz_grading_report->display()

Attachments

Issue Links

Testing discovered

MDL-42220 Alternate name fields notices when manual grading quiz attempts

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Ankit Agarwal

Integrator:: Marina Glancy

Tester:: Rajesh Taneja

Participants:: Ankit Agarwal, Eloy Lafuente (stronk7), Marina Glancy, Rajesh Taneja, Tim Hunt

Component watchers:: Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 25/Oct/13 2:30 PM

Updated:: 15/Nov/13 7:49 PM

Resolved:: 15/Nov/13 7:49 PM

Fix Release Date:: 18/Nov/13