Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42547

Bulk users upload: values are not trimmed in CSV file when bulk uploading users

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.7, 2.5, 2.5.3, 2.6
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Note: You will get debugging messages testing this in 2.5, 2.6/master - this will be resolved by MDL-42885.

      1. Visit <yoursite>/admin/tool/uploaduser/index.php upload the the attached file and click 'Upload users'.
      2. Ensure there is no warning about the email address being invalid in the preview table and click 'Upload users' again.
      3. Ensure there is no warning about the email address being invalid in the summary table and that the users were uploaded successfully.
      4. Check the mdl_user table and ensure that their emails do not contain spaces at the start and end.
      5. Edit the file slightly by changing the user's emails (but leave the white space at the start and end).
      6. Visit <yoursite>/admin/tool/uploaduser/index.php and upload this file again (but do not finalise the upload).
      7. Ensure there is no warning about the email address being invalid in the preview table.
      8. Check "Update existing users only" and set "Existing user details" with "Override with file" and click "Upload users"
      9. Check that the next page says that the emails were updated.
      10. Ensure there is no warning about the email address being invalid in the summary table and that they upload successfully.
      11. Check the mdl_user table and ensure that their emails have been updated do not contain spaces at the start and end.
      Show
      Note: You will get debugging messages testing this in 2.5, 2.6/master - this will be resolved by MDL-42885 . Visit <yoursite>/admin/tool/uploaduser/index.php upload the the attached file and click 'Upload users'. Ensure there is no warning about the email address being invalid in the preview table and click 'Upload users' again. Ensure there is no warning about the email address being invalid in the summary table and that the users were uploaded successfully. Check the mdl_user table and ensure that their emails do not contain spaces at the start and end. Edit the file slightly by changing the user's emails (but leave the white space at the start and end). Visit <yoursite>/admin/tool/uploaduser/index.php and upload this file again (but do not finalise the upload). Ensure there is no warning about the email address being invalid in the preview table. Check "Update existing users only" and set "Existing user details" with "Override with file" and click "Upload users" Check that the next page says that the emails were updated. Ensure there is no warning about the email address being invalid in the summary table and that they upload successfully. Check the mdl_user table and ensure that their emails have been updated do not contain spaces at the start and end.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42547_master
    • Story Points:
      8
    • Sprint:
      BACKEND Sprint 7

      Description

      Bulk upload csv file with users whole emails for some reason not clean and contain space at the end or beginning will be recorded in Moodle as it is, resulting in impossibility to send email to user. The best approach would be to strip beginning/end spaces for email (and potentially other fields).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14