Moodle
  1. Moodle
  2. MDL-42548

Quiz displays grade for a never-submitted attempt as 'Attempt still in progress'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a quiz with a (short) time limit, and 'Students must submit attempts or they are not counted.'
      2. Start an attempt as a student, then close that browser window without submitting.
      3. A few minutes after time has expired, go in as the teacher and to Results -> Grades.
      4. This attempt will shown as Never submitted. (If it still says In progress, wait longer, and run cron if necessary.)
      5. Click on the Review attempt icon. In the table at the top, it should show the attempt state, but not the grade.
      6. Now attempt the quiz as another student and submit it.
      7. Review that attempt as student and teacher and ensure the grade is displayed. (Well the grade will only display to students if the review options allow it.)
      Show
      Create a quiz with a (short) time limit, and 'Students must submit attempts or they are not counted.' Start an attempt as a student, then close that browser window without submitting. A few minutes after time has expired, go in as the teacher and to Results -> Grades. This attempt will shown as Never submitted. (If it still says In progress, wait longer, and run cron if necessary.) Click on the Review attempt icon. In the table at the top, it should show the attempt state, but not the grade. Now attempt the quiz as another student and submit it. Review that attempt as student and teacher and ensure the grade is displayed. (Well the grade will only display to students if the review options allow it.)
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Gliffy Diagrams

        Activity

        Hide
        Tim Hunt added a comment -

        Ready for peer review.

        Show
        Tim Hunt added a comment - Ready for peer review.
        Hide
        Jason Fowler added a comment -

        Hi Tim, while the patch looks decent, I am concerned about the case of a student who is indeed still in the middle of a quiz attempt. What will this display then? I am guessing it won't allow the teacher to grade it, which is right, but we have the loss of functionality where it tells the teacher the attempt is still in progress. Is this the expected outcome of this change? If so, just submit for integration, as the patch is good to go.

        Show
        Jason Fowler added a comment - Hi Tim, while the patch looks decent, I am concerned about the case of a student who is indeed still in the middle of a quiz attempt. What will this display then? I am guessing it won't allow the teacher to grade it, which is right, but we have the loss of functionality where it tells the teacher the attempt is still in progress. Is this the expected outcome of this change? If so, just submit for integration, as the patch is good to go.
        Hide
        Tim Hunt added a comment -

        Hi Jason. Thanks for the review.

        Just above where it no longer says Grade: Attempt in progress, there is another line of information State: In progress. (Hmm... not the most user-friendly language. Something for another day.) That should be sufficient.

        So, submitting for integration.

        (State: In progress / Overdue / Complete / Never submitted was added in Moodle 2.3, that would have been the logical moment to remove the old Grade: Attempt in progress message, but no one noticed until now.)

        Show
        Tim Hunt added a comment - Hi Jason. Thanks for the review. Just above where it no longer says Grade: Attempt in progress, there is another line of information State: In progress. (Hmm... not the most user-friendly language. Something for another day.) That should be sufficient. So, submitting for integration. (State: In progress / Overdue / Complete / Never submitted was added in Moodle 2.3, that would have been the logical moment to remove the old Grade: Attempt in progress message, but no one noticed until now.)
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 25 and 24 - thanks Tim

        Show
        Dan Poltawski added a comment - Integrated to master, 25 and 24 - thanks Tim
        Hide
        Rajesh Taneja added a comment -

        Thanks Tim,

        Works as expected... Passing...

        Show
        Rajesh Taneja added a comment - Thanks Tim, Works as expected... Passing...
        Hide
        Damyon Wiese added a comment -

        Here lies 52 bugs.
        All fixed or swept under a rug.
        If they come back one day,
        To our dismay,
        We all will feel quite un-smug.

        Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

        Show
        Damyon Wiese added a comment - Here lies 52 bugs. All fixed or swept under a rug. If they come back one day, To our dismay, We all will feel quite un-smug. Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: