Moodle
  1. Moodle
  2. MDL-42563

filter/algebra missing thirdpartylibs.xml

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.5.2
        • Fix Version/s: 2.6.1
        • Component/s: Filters, Libraries
        • Labels:

          Description

          AlgParser.pm seems to me like a 3-rd party lib. One repository with that code I've is at http://webwork.maa.org/viewvc/system/trunk/pg/?diff_format=c .

          If it is not a 3-rd party lib then it's missing standard Moodle header with copyright and license information.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Michael de Raadt added a comment -

              Thanks for spotting that. Feel free to put up a thirdpartylibs.xml file.

              Show
              Michael de Raadt added a comment - Thanks for spotting that. Feel free to put up a thirdpartylibs.xml file.
              Hide
              Permalink
              Petr Skoda added a comment -

              Hello, looks like the GPl version should be 2+ because 2 would mean we need to upgrade to make it compatible with the rest of moodle.

              Show
              Petr Skoda added a comment - Hello, looks like the GPl version should be 2+ because 2 would mean we need to upgrade to make it compatible with the rest of moodle.
              Hide
              Permalink
              Tomasz Muras added a comment -

              You are correct, thankfully the license says "or any later". Fixed.

              Show
              Tomasz Muras added a comment - You are correct, thankfully the license says "or any later". Fixed.
              Hide
              Permalink
              Petr Skoda added a comment -

              Thanks a lot, sending to integration

              Show
              Petr Skoda added a comment - Thanks a lot, sending to integration
              Hide
              Permalink
              Dan Poltawski added a comment -

              Hi Tomasz,

              I think this is a bug and should be back ported to the stable branches.

              I can cherry-pick for 2.6, but can you provide fixes for the other branches? (They will be different due to the thirdpartylibs change).

              thanks!

              Show
              Dan Poltawski added a comment - Hi Tomasz, I think this is a bug and should be back ported to the stable branches. I can cherry-pick for 2.6, but can you provide fixes for the other branches? (They will be different due to the thirdpartylibs change). thanks!
              Hide
              Permalink
              Petr Skoda added a comment -

              Please no bacports, the 2.6 already diverted from previous list, we did not backport missing libs and fixes during 2.6dev.

              Show
              Petr Skoda added a comment - Please no bacports, the 2.6 already diverted from previous list, we did not backport missing libs and fixes during 2.6dev.
              Hide
              Permalink
              Dan Poltawski added a comment -

              I suppose its fair enough, integrated to master and 26.

              Show
              Dan Poltawski added a comment - I suppose its fair enough, integrated to master and 26.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Thanks for your contributions, this change is now upstream!

              “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

              Show
              Dan Poltawski added a comment - Thanks for your contributions, this change is now upstream! “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: