Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42634

When a block/activity is hidden and editing is on the action menu is dimmed as well.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test on each of the following themes:

      1. clean
      2. canvas
      3. base
      1. Navigate to a course
      2. Turn editing on.
      3. Hide a block
      4. Open its action menu
        1. Verify that the block looks dimmed
        2. Verify that the action menu does not look dimmed and is not see-through
        3. Verify that the command icons (e.g. dock) are fully visible
      5. Hide an activity, and open its action menu
        1. Verify that the activity looks dimmed
        2. Verify that the action menu does not look dimmed and is not see-through
        3. Verify that the icon for the activity icon is also dimmed
        4. Verify that the groups icon is fully visible
      6. Hide a section which contains at least one activity
      7. Open the action menu for one of the activities
        1. Verify that the action menu does not look dimmed and is not see-through
        2. Verify that the activity looks dimmed
        3. Verify that the icon for the activity icon is also dimmed
        4. Verify that the groups icon is fully visible
      Show
      Test on each of the following themes: clean canvas base Navigate to a course Turn editing on. Hide a block Open its action menu Verify that the block looks dimmed Verify that the action menu does not look dimmed and is not see-through Verify that the command icons (e.g. dock) are fully visible Hide an activity, and open its action menu Verify that the activity looks dimmed Verify that the action menu does not look dimmed and is not see-through Verify that the icon for the activity icon is also dimmed Verify that the groups icon is fully visible Hide a section which contains at least one activity Open the action menu for one of the activities Verify that the action menu does not look dimmed and is not see-through Verify that the activity looks dimmed Verify that the icon for the activity icon is also dimmed Verify that the groups icon is fully visible
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-42634-master
    • Sprint:
      Team Beards Sprint 9, Team Beards Sprint 10
    • Issue size:
      Medium

      Description

      Andrew noticed this, when a block is hidden + editing is on + the user clicks the blocks action menu the action menu is shown light grey.
      In the standard theme this is because the block is "hidden" by setting its opacity to 0.5.

      Really the action menu needs to be perfectly visible, this is a larger change because it means that we must change how we show hidden blocks because of how opacity is handled.

        Attachments

        1. 20150810_hiddenactivity.png
          41 kB
          Andrew Nicols
        2. 20150810_hiddenblock.png
          32 kB
          Andrew Nicols
        3. 20150810_hiddensection.png
          34 kB
          Andrew Nicols
        4. 20150810_oblique_a.png
          9 kB
          Andrew Nicols
        5. 20150810_oblique_b.png
          42 kB
          Andrew Nicols
        6. 20150810_oblique_s.png
          43 kB
          Andrew Nicols
        7. action_menu_not_dimmed.png
          20 kB
          Marina Glancy
        8. Before this fix..png
          97 kB
          Rajesh Taneja
        9. screenshot-1.png
          125 kB
          Rajesh Taneja

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Dan Poltawski
              Tester:
              Marina Glancy
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              33 Vote for this issue
              Watchers:
              35 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15