[MDL-42638] Emoticon filter interferes with <pre> content - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5.2, 2.8.1, 3.6.6, 3.7.2, 3.8
Fix Version/s: 3.6.7, 3.7.3
Component/s: Filters
Labels:
- ci
- moodle.org
- patch
- triaged

Testing Instructions:

Hide

Automated tests provided.

Show
Automated tests provided.

Workaround:

Hide

It should be possible to embed the code to be shown in

<span class="nolink">

<pre>

- (id)initWithBitmapDataPlanes:(unsigned char **)planes

                    pixelsWide:(NSInteger)width

                    pixelsHigh:(NSInteger)height

                 bitsPerSample:(NSInteger)bps

               samplesPerPixel:(NSInteger)spp

                      hasAlpha:(BOOL)alpha

                      isPlanar:(BOOL)isPlanar

                colorSpaceName:(NSString *)colorSpaceName

                  bitmapFormat:(NSBitmapFormat)bitmapFormat

                   bytesPerRow:(NSInteger)rowBytes

                  bitsPerPixel:(NSInteger)pixelBits;

</pre>

</span>

Show

It should be possible to embed the code to be shown in <pre> - (id)initWithBitmapDataPlanes:(unsigned char **)planes pixelsWide:(NSInteger)width pixelsHigh:(NSInteger)height bitsPerSample:(NSInteger)bps samplesPerPixel:(NSInteger)spp hasAlpha:(BOOL)alpha isPlanar:(BOOL)isPlanar colorSpaceName:(NSString *)colorSpaceName bitmapFormat:(NSBitmapFormat)bitmapFormat bytesPerRow:(NSInteger)rowBytes bitsPerPixel:(NSInteger)pixelBits; </pre>

Affected Branches:
MOODLE_25_STABLE, MOODLE_28_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Pull from Repository:
https://github.com/lucaboesch/moodle
Pull 3.6 Branch:
~~MDL-42638~~-36
Pull 3.6 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_36_STABLE...lucaboesch:MDL-42638-36
Pull 3.7 Branch:
~~MDL-42638~~-37
Pull 3.7 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_37_STABLE...lucaboesch:MDL-42638-37
Pull Master Branch:
~~MDL-42638~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...lucaboesch:MDL-42638-master

Description

1. Enable the emoticon filter on your site
2. Create a forum post with the following content:

Test content:

<pre>

- (id)initWithBitmapDataPlanes:(unsigned char **)planes

                    pixelsWide:(NSInteger)width

                    pixelsHigh:(NSInteger)height

                 bitsPerSample:(NSInteger)bps

               samplesPerPixel:(NSInteger)spp

                      hasAlpha:(BOOL)alpha

                      isPlanar:(BOOL)isPlanar

                colorSpaceName:(NSString *)colorSpaceName

                  bitmapFormat:(NSBitmapFormat)bitmapFormat

                   bytesPerRow:(NSInteger)rowBytes

                  bitsPerPixel:(NSInteger)pixelBits;

</pre>

Expected result:
The content in <pre> is preserved

Actual result:
Sad smiley face images are replaced in the pre content.

Attachments

Issue Links

has a non-specific relationship to

MDL-61732 Allow "Mathjax" and "Display emoticons as images" filter together, have "y(n)" not breaking

Closed

Activity

People

Assignee:

Luca Bösch

Reporter:

Dan Poltawski

Peer reviewer:

Jan Dageförde

Integrator:

Eloy Lafuente (stronk7)

Tester:

CiBoT

Participants:

CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Jan Dageförde, Luca Bösch, Marina Glancy, Werner Cyrmon

Component watchers:

Jake Dallimore, Jun Pataleta

Votes:

3 Vote for this issue

Watchers:

6 Start watching this issue

Dates

Created:

31/Oct/13 8:48 PM

Updated:

08/Nov/19 11:10 PM

Resolved:

08/Nov/19 11:10 PM

Fix Release Date:

11/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

45m