Affects Version/s: 2.5.2
Fix Version/s: 2.5.2
- Comment out fix adding set_pagelayout() in line 36 in grade/edit/outcome/import.php
- Switch to Clean them
- Enable Outcomes (advanced features)
- Open course gradebook
- Select in dropdown 'Import outcomes'
- Make sure there are no errors on page but layout may look weird
Pull from Repository:
Pull Master Branch:
Pull Master Diff URL:
As found in
MDL-40971 Clean theme throws an exception if $PAGE->set_pagelayout() is changed after output is initialised.
Obviously in each particular case we should fix the call to set_pagelayout() like Mary did in
But in the generic case since we don't show any warnings (they are commented out) inside the set_pagelayout() function, theme should be more tolerant to it as well. Standard-like themes have some php code inside layout files checking if block regions are not empty:
Bootstrapbase/clean should do something similar. AFAIK Sam Hemelryk was trying to avoid php code in layout files, maybe we can insert the check in renderer then?