Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42660

Toolbars: the spacing is too large (standard and clean)

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42660-master-alt
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Note for tester - if you have customised your tinymce toolbar - restore it to the default toolbar before applying this patch.

      • Using clean and standard in supported browsers
      1. Look at the icons/toolbars for TinyMCE, Filemanager, Filepicker and the EditPDF tool in Assignment submission grading.
      2. Ensure they look right
      • Ignore editor widths etc, these have already been raised and are being worked on already.

      To test MDL-42620 in this issue too:

      In clean and standard themes, using supported browsers:

      • Open a page with a filemanager
      • Check the selected view's button's background looks slightly darker than the hover state
      • Hover over the button
      • Check that it gets lighter
      • Select another view button and repeat above steps
      Show
      Note for tester - if you have customised your tinymce toolbar - restore it to the default toolbar before applying this patch. Using clean and standard in supported browsers Look at the icons/toolbars for TinyMCE, Filemanager, Filepicker and the EditPDF tool in Assignment submission grading. Ensure they look right Ignore editor widths etc, these have already been raised and are being worked on already. To test MDL-42620 in this issue too: In clean and standard themes, using supported browsers: Open a page with a filemanager Check the selected view's button's background looks slightly darker than the hover state Hover over the button Check that it gets lighter Select another view button and repeat above steps

      Description

      TinyMCE - It doesn't display entirely on macbook air 11'' (just to mention a common computer, but I guess whatever the screen size it should be appearing without scrollbar).
      Filepicker/Manager - It's terrible on a phone
      EditPDF - will need to be updated to match

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42684 Width of TinyMCE iframe narrower than bounding area

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42789 New TinyMCE does not fit in the question editing forms

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42102 Style TinyMCE toolbars consistently with Moodle style

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              phalacee Jason Fowler
              Reporter:
              jerome Jérôme Mouneyrac
              Peer reviewer:
              Rossiani Wijaya Rossiani Wijaya
              Integrator:
              Damyon Wiese Damyon Wiese
              Tester:
              Petr Skoda Petr Skoda
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13