Hi David,

Just a minor fix for spacing on this line https://github.com/dmonllao/moodle/commit/bb7603f4a324257e24066b2bda691daacc6edd17#diff-ef19ca6b08229a8ac4ab12bd050361e1R52

[y] Syntax
[y] Whitespace, above message
[y] Output
[-] Language
[-] Databases
[y] Testing (instructions and automated tests)
[-] Security
[-] Documentation
[y] Git
[]- Third party code
[y] Sanity check

Other than the above message. The patch look great. Thanks for fixing.

Thanks Rossie, sending to integration

Thanks David - phantom for the win!

Integrated to 24, 25 and master.

(I tested on master and the fix worked for me).

This doesn't pass our linter either...

parseInt() needs a radix in the second param, and we should do strict equality comparisons.

and typeof is not a function, it's an operator:

if (typeof clocksettings !== undefined) {

    if (clocksettings.starttime) {

        starttime = parseInt(clocksettings.starttime, 10);

    }

...

}

is just a copy & paste of the current code, is the current code passing our linter?

in this case the code was just moved and we do not want to add regressions.

Hmm okay. We should really pick up those radix changes whenever possible as they do have potential to cause whacky things in certain situations (e.g. if passed a number with a leading zero, they change behaviour to base 8).

Works as expected. Passing.

Here lies 52 bugs.
All fixed or swept under a rug.
If they come back one day,
To our dismay,
We all will feel quite un-smug.

Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.