Moodle
  1. Moodle
  2. MDL-26254 $CFG->perfdebug uses confusing values
  3. MDL-42664

Moodle always instantiates slower performance_measuring_filter_manager()

        Details

        • Testing Instructions:
          Hide
          • Make sure that text filtering works (by having some text filter enabled)
          • In Moodle 2.6, run unit tests 

            $ phpunit lib/tests/filterlib_test.php

          • In Moodle 2.5, run unit test 

            $ phpunit filter_manager_testcase lib/tests/filter_test.php

          • No unit testing possible in Moodle 2.4 because there is no way to reset the static singleton cache.
          Show
          Make sure that text filtering works (by having some text filter enabled) In Moodle 2.6, run unit tests $ phpunit lib/tests/filterlib_test.php In Moodle 2.5, run unit test $ phpunit filter_manager_testcase lib/tests/filter_test.php No unit testing possible in Moodle 2.4 because there is no way to reset the static singleton cache.
        • Affected Branches:
          MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-42664-performance_measuring_filter_manager
        • Pull Master Diff URL:

          Description

          See the description and comments in the parent issue.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              David Mudrak added a comment -

              This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.

              Show
              David Mudrak added a comment - This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.
              Hide
              Permalink
              David Mudrak added a comment -

              Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.

              Show
              David Mudrak added a comment - Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.
              Hide
              Permalink
              Marina Glancy added a comment -

              Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6

              Show
              Marina Glancy added a comment - Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6
              Hide
              Permalink
              Adrian Greeve added a comment -

              All the unit tests mentioned passed.
              Filters still work.
              Tested on the 2.4, 2.5 and master integration branches.
              Test passed.

              Show
              Adrian Greeve added a comment - All the unit tests mentioned passed. Filters still work. Tested on the 2.4, 2.5 and master integration branches. Test passed.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              It's Friday, I'm tired so I won't be very imaginative today.

              No matter of that, yes, you did it! Thanks for your collaboration!

              Closing this as fixed!

              Show
              Eloy Lafuente (stronk7) added a comment - It's Friday, I'm tired so I won't be very imaginative today. No matter of that, yes, you did it! Thanks for your collaboration! Closing this as fixed!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: