Moodle
  1. Moodle
  2. MDL-26254 $CFG->perfdebug uses confusing values
  3. MDL-42664

Moodle always instantiates slower performance_measuring_filter_manager()

    Details

    • Rank:
      54497

      Description

      See the description and comments in the parent issue.

        Activity

        Hide
        David Mudrak added a comment -

        This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.

        Show
        David Mudrak added a comment - This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.
        Hide
        David Mudrak added a comment -

        Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.

        Show
        David Mudrak added a comment - Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.
        Hide
        Marina Glancy added a comment -

        Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6

        Show
        Marina Glancy added a comment - Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6
        Hide
        Adrian Greeve added a comment -

        All the unit tests mentioned passed.
        Filters still work.
        Tested on the 2.4, 2.5 and master integration branches.
        Test passed.

        Show
        Adrian Greeve added a comment - All the unit tests mentioned passed. Filters still work. Tested on the 2.4, 2.5 and master integration branches. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        It's Friday, I'm tired so I won't be very imaginative today.

        No matter of that, yes, you did it! Thanks for your collaboration!

        Closing this as fixed!

        Show
        Eloy Lafuente (stronk7) added a comment - It's Friday, I'm tired so I won't be very imaginative today. No matter of that, yes, you did it! Thanks for your collaboration! Closing this as fixed!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: