Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.5.2
-
Component/s: Filters, Performance
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:
MDL-42664-performance_measuring_filter_manager_24 -
Pull 2.5 Branch:
MDL-42664-performance_measuring_filter_manager_25 -
Pull Master Branch:
MDL-42664-performance_measuring_filter_manager
-
Rank:54497
Description
See the description and comments in the parent issue.
Activity
Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.
Show
David Mudrak
added a comment - Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.
Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6
Show
Marina Glancy
added a comment - Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6
All the unit tests mentioned passed.
Filters still work.
Tested on the 2.4, 2.5 and master integration branches.
Test passed. 
Show
Adrian Greeve
added a comment - All the unit tests mentioned passed.
Filters still work.
Tested on the 2.4, 2.5 and master integration branches.
Test passed.
It's Friday, I'm tired so I won't be very imaginative today.
No matter of that, yes, you did it! Thanks for your collaboration!
Closing this as fixed!
Show
Eloy Lafuente (stronk7)
added a comment - It's Friday, I'm tired so I won't be very imaginative today.
No matter of that, yes, you did it! Thanks for your collaboration!
Closing this as fixed!
This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.