Moodle always instantiates slower performance_measuring_filter_manager()

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.5.2
Fix Version/s: 2.4.6, 2.5.2, 2.6
Component/s: Filters, Performance
Labels:
- triaged

Testing Instructions:
Hide

Make sure that text filtering works (by having some text filter enabled)

In Moodle 2.6, run unit tests

$ phpunit lib/tests/filterlib_test.php

In Moodle 2.5, run unit test

$ phpunit filter_manager_testcase lib/tests/filter_test.php

No unit testing possible in Moodle 2.4 because there is no way to reset the static singleton cache.
Show
Make sure that text filtering works (by having some text filter enabled) In Moodle 2.6, run unit tests $ phpunit lib/tests/filterlib_test.php In Moodle 2.5, run unit test $ phpunit filter_manager_testcase lib/tests/filter_test.php No unit testing possible in Moodle 2.4 because there is no way to reset the static singleton cache.
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull 2.4 Branch:
~~MDL-42664~~-performance_measuring_filter_manager_24
Pull 2.4 Diff URL:
https://github.com/mudrd8mz/moodle/compare/75d8d06ffbb26f5f12b8a69a47f6ba7f425369b0...f23a63b545496a270739324f9a14bdf5f4f5721a
Pull 2.5 Branch:
~~MDL-42664~~-performance_measuring_filter_manager_25
Pull 2.5 Diff URL:
https://github.com/mudrd8mz/moodle/compare/67d4599aff97404957994aa818ea14c274e11016...2c6520c719c370f3ec0449fa33da699277abbeda
Pull Master Branch:
~~MDL-42664~~-performance_measuring_filter_manager
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/5386f0bbfe279002af3ca217ff50615449dc652f...c928c607185bbc659421701a33e06246b7e36c96

Description

See the description and comments in the parent issue.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Mudrak added a comment - 01/Nov/13 8:30 AM

This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.

Show

David Mudrak added a comment - 01/Nov/13 8:30 AM This has been peer-reviewed and approved by Eloy and Petr in the parent issue. Submitting for integration.

Hide

Permalink

David Mudrak added a comment - 01/Nov/13 8:34 AM

Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.

Show

David Mudrak added a comment - 01/Nov/13 8:34 AM Performance boost has been reported in the parent issue. Because this is pretty trivial change (and should have been fixed long ago if I did not loose it from my radar), I think it might go into next releases.

Hide

Permalink

Marina Glancy added a comment - 04/Nov/13 2:20 AM

Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6

Show

Marina Glancy added a comment - 04/Nov/13 2:20 AM Thanks David, great fix. Integrated in 2.4, 2.5 and 2.6

Hide

Permalink

Adrian Greeve added a comment - 04/Nov/13 4:32 AM

All the unit tests mentioned passed.
Filters still work.
Tested on the 2.4, 2.5 and master integration branches.
Test passed.

Show

Adrian Greeve added a comment - 04/Nov/13 4:32 AM All the unit tests mentioned passed. Filters still work. Tested on the 2.4, 2.5 and master integration branches. Test passed.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 15/Nov/13 11:50 AM

It's Friday, I'm tired so I won't be very imaginative today.

No matter of that, yes, you did it! Thanks for your collaboration!

Closing this as fixed!

Show

Eloy Lafuente (stronk7) added a comment - 15/Nov/13 11:50 AM It's Friday, I'm tired so I won't be very imaginative today. No matter of that, yes, you did it! Thanks for your collaboration! Closing this as fixed!

People

Assignee:

David Mudrak

Reporter:

David Mudrak

Integrator:

Marina Glancy

Tester:

Adrian Greeve

Participants:

Adrian Greeve, David Mudrak, Eloy Lafuente (stronk7), Marina Glancy

Vote (0)

Watch (5)

Dates

Created:

01/Nov/13 6:04 AM

Updated:

15/Nov/13 11:50 AM

Resolved:

15/Nov/13 11:50 AM

Agile

View on Board