Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42677

Scorm package in tests/packages produces warnings

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE

      Description

      I was trying to write a behat test for creating SCORM and IMSCP modules and was trying to use file /mod/scorm/tests/packages/validscorm.zip

      Creating a module with this package via web-interface produces the warnings.

      When creating SCORM:

      ( ! ) Notice: Undefined property: stdClass::$elements in /home/marina/repositories/int_master/integration/mod/scorm/datamodels/scormlib.php on line 529
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0016	356176	{main}( )	../modedit.php:0
      2	0.5962	37749272	add_moduleinfo( )	../modedit.php:272
      3	0.6132	37802872	scorm_add_instance( )	../modlib.php:98
      4	0.6688	37980184	scorm_parse( )	../lib.php:162
      5	0.6899	38244704	scorm_parse_scorm( )	../locallib.php:276
      

      When creating IMSCP:

      ( ! ) Warning: DOMDocument::loadXML(): Start tag expected, '<' not found in Entity, line: 2 in /home/marina/repositories/int_master/integration/mod/imscp/locallib.php on line 108
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0030	342400	{main}( )	../modedit.php:0
      2	0.4942	36514392	add_moduleinfo( )	../modedit.php:272
      3	0.5155	36567704	imscp_add_instance( )	../modlib.php:98
      4	0.5770	36785256	imscp_parse_structure( )	../lib.php:112
      5	0.5784	36790192	imscp_parse_manifestfile( )	../locallib.php:98
      6	0.5784	36791064	DOMDocument->loadXML( )	../locallib.php:108
      

      We need either to submit a really valid scorm package or fix those notices/warnings in code. I'm not sure what is the correct way
      Reproduced on 2.4, 2.5 and 2.6.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              marina Marina Glancy
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: