Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42690

Do not show the submit button when viewing single grading page

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6, FRONTEND
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to a course and enrol a teacher
      3. Add an assignment module and set require user to submit to true
      4. Edit the permissions for the assignment and give teachers mod/assign:submit
      5. Log in as the teacher
      6. Enter the assignment and upload a PDF as a submission. DO NOT CLICK SUBMIT
      7. Browse to the submission grading screen and click to grade the teachers submission.
      8. Check you don't get the submit button.
      Show
      Log in as an admin Browse to a course and enrol a teacher Add an assignment module and set require user to submit to true Edit the permissions for the assignment and give teachers mod/assign:submit Log in as the teacher Enter the assignment and upload a PDF as a submission. DO NOT CLICK SUBMIT Browse to the submission grading screen and click to grade the teachers submission. Check you don't get the submit button.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      42690-26
    • Pull Master Diff URL:

      Description

      As suggested by Damyon on MDL-42350 there is really no point in showing the submit button with browsing through view_single_grade_page.

      At the very least we should convert it to use the new show_submit_button method, however removing it is probably the better option here.

      Turned into a new issue because release is ultra-close.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13