[MDL-42706] Undefined $CFG in mod_book pluginfile - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.6
Fix Version/s: 2.6
Component/s: Book
Labels:
- triaged

Testing Instructions:
Hide

Repeat the QA ~~MDLQA-6258~~

Make sure you don't see any notice in your error logs
Show
Repeat the QA MDLQA-6258 Make sure you don't see any notice in your error logs
Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-42706~~-master-int
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/4816e19...MDL-42706-master-int

Description

While testing ~~MDLQA-6258~~, I found this notice in my logs:

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP Notice:  Undefined variable: CFG in /home/fred/www/repositories/im/moodle/mod/book/lib.php on line 446, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP Stack trace:, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   1. {main}() /home/fred/www/repositories/im/moodle/pluginfile.php:0, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   2. file_pluginfile() /home/fred/www/repositories/im/moodle/pluginfile.php:37, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   3. book_pluginfile() /home/fred/www/repositories/im/moodle/lib/filelib.php:4569, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP Notice:  Trying to get property of non-object in /home/fred/www/repositories/im/moodle/mod/book/lib.php on line 446, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP Stack trace:, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   1. {main}() /home/fred/www/repositories/im/moodle/pluginfile.php:0, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   2. file_pluginfile() /home/fred/www/repositories/im/moodle/pluginfile.php:37, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

[Tue Nov 05 13:10:23 2013] [error] [client 192.168.100.54] PHP   3. book_pluginfile() /home/fred/www/repositories/im/moodle/lib/filelib.php:4569, referer: https://fred.moodle.local/im/mod/book/view.php?id=3658

Attachments

Issue Links

is a regression caused by

MDL-42387 Revisit CFG->filelifetime implementation and uses

Closed

Activity

People

Assignee:

Frédéric Massart

Reporter:

Frédéric Massart

Peer reviewer:

Petr Skoda

Integrator:

Marina Glancy

Tester:

Rossiani Wijaya

Participants:

Eloy Lafuente (stronk7), Frédéric Massart, Marina Glancy, Petr Skoda, Rossiani Wijaya

Component watchers:

David Jones, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

05/Nov/13 1:17 PM

Updated:

15/Nov/13 7:50 PM

Resolved:

15/Nov/13 7:50 PM

Fix Release Date:

18/Nov/13