Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42732

List of unapproved entries not shown on oracle

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.5.2
    • Fix Version/s: None
    • Component/s: Glossary
    • Labels:
    • Testing Instructions:
      Hide

      Important This needs to be tested on all four databases.

      1. Create a glossary
      2. Set "Approved by default" to No
      3. Log on as a student and create an entry
      4. Logout and log in as a teacher / administrator
      5. Go back to the glossary and click on the link for entries that require approval.
      6. Check that there are entries that require approval. Don't approve yet.
      7. Click on the letter that corresponds with the first letter of the glossary concept that requires approval.
      8. Make sure that the entry is still displayed ready to be approved.
      9. Approve the entry.
      10. Do a key word search for the concept
      11. Do a key word search for something in the definition.
      12. Edit the concept and give it a keyword.
      13. Do the above searches again.
      14. Create a category and add the entry to the category.
      15. Do the above searches again.
      16. Try each of the different tabs for Browsing (e.g. Browse by category)
      Show
      Important This needs to be tested on all four databases. Create a glossary Set "Approved by default" to No Log on as a student and create an entry Logout and log in as a teacher / administrator Go back to the glossary and click on the link for entries that require approval. Check that there are entries that require approval. Don't approve yet. Click on the letter that corresponds with the first letter of the glossary concept that requires approval. Make sure that the entry is still displayed ready to be approved. Approve the entry. Do a key word search for the concept Do a key word search for something in the definition. Edit the concept and give it a keyword. Do the above searches again. Create a category and add the entry to the category. Do the above searches again. Try each of the different tabs for Browsing (e.g. Browse by category)
    • Affected Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-42732-master
    • Pull Master Diff URL:

      Description

      This fails on oracle, when we follow 'Waiting approval', no entires are shown:

        Scenario: Approve and disapprove glossary entries
      		 
          Given the following "users" exists:
      		 
            | username | firstname | lastname | email |
      		 
            | teacher1 | Teacher | 1 | teacher1@asd.com |
      		 
            | student1 | Student | 1 | student1@asd.com |
      		 
            | student2 | Student | 2 | student2@asd.com |
      		 
          And the following "courses" exists:
      		 
            | fullname | shortname | category |
      		 
            | Course 1 | C1 | 0 |
      		 
          And the following "course enrolments" exists:
      		 
            | user | course | role |
      		 
            | teacher1 | C1 | editingteacher |
      		 
            | student1 | C1 | student |
      		 
            | student2 | C1 | student |
      		 
          And I log in as "teacher1"
      		 
          And I follow "Course 1"
      		 
          And I turn editing mode on
      		 
          Given I add a "Glossary" to section "1" and I fill the form with:
      		 
            | Name | Test glossary name |
      		 
            | Description | Test glossary entries require approval |
      		 
            | Approved by default | No |
      		 
          And I log out
      		 
          And I log in as "student1"
      		 
          And I follow "Course 1"
      		 
          And I follow "Test glossary name"
      		 
          When I add a glossary entry with the following data:
      		 
            | Concept | Just a test concept |
      		 
            | Definition | Concept definition |
      		 
            | Keyword(s) | Black |
      		 
          And I log out
      		 
          # Test that students can not see the unapproved entry.
      		 
          And I log in as "student2"
      		 
          And I follow "Course 1"
      		 
          And I follow "Test glossary name"
      		 
          Then I should see "No entries found in this section"
      		 
          And I log out
      		 
          # Approve the entry.
      		 
          And I log in as "teacher1"
      		 
          And I follow "Course 1"
      		 
          And I follow "Test glossary name"
      		 
          And I follow "Waiting approval"

      Expected result:

      • List of unapproved entires shown

      Actual result:

      • No unapproved entries are shown

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42912 Unapproved glossary entries are not shown for teacher (Oracle only)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Functional Test - A test of a single Moodle feature MDLQA-6334 CLONE - Upgrade test from previous version of Moodle on Oracle with Apache

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Passed

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Andrew Davis Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: