Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42733

Undetected notice by behat

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Revert change from MDL-43006
      2. Run behat with --tags @mod_glossary
      3. You SHOULD see a failure

      01. PHP debug message/s found:
          
          Notice: Undefined property: stdClass::$aliases in /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/edit.php on line 94
          In step `When I add a glossary entry with the following data:'.                                # behat_mod_glossary::i_add_a_glossary_entry_with_the_following_data()
          From scenario `Printer-friendly glossary view disabled'.                                       # /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/tests/behat/print_friendly_version.feature:41
          Of feature `A teacher can choose whether to provide a printer-friendly glossary entries list'. # /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/tests/behat/print_friendly_version.feature
      

      Test 2

      1. Run the whole behat suite or wait for CI to finish
      2. If there are other failures they SHOULD all be PHP debug message/s found errors
      Show
      Test 1 Revert change from MDL-43006 Run behat with --tags @mod_glossary You SHOULD see a failure 01. PHP debug message/s found: Notice: Undefined property: stdClass::$aliases in /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/edit.php on line 94 In step `When I add a glossary entry with the following data:'. # behat_mod_glossary::i_add_a_glossary_entry_with_the_following_data() From scenario `Printer-friendly glossary view disabled'. # /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/tests/behat/print_friendly_version.feature:41 Of feature `A teacher can choose whether to provide a printer-friendly glossary entries list'. # /home/davidm/Desktop/moodlecode/INTEGRATION/master/mod/glossary/tests/behat/print_friendly_version.feature Test 2 Run the whole behat suite or wait for CI to finish If there are other failures they SHOULD all be PHP debug message/s found errors
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42733_master

      Description

      When running the feature file mod/glossary/tests/behat/print_friendly_version.feature a php notice is experienced (and displayed in the error log).

      This should cause a behat failure, but it is not being detected.

      Running Behat tests
      ..............................
       
      2 scenarios (2 passed)
      30 steps (30 passed)
      0m56.415s
      

      [Wed Nov 06 12:32:38 2013] [error] [client ::1] PHP Notice:  Undefined property: stdClass::$aliases in /Users/danp/moodles/im/moodle/mod/glossary/edit.php on line 94, referer: http://dan.moodle.local/im/mod/glossary/edit.php?cmid=1
      [Wed Nov 06 12:32:38 2013] [error] [client ::1] PHP Stack trace:, referer: http://dan.moodle.local/im/mod/glossary/edit.php?cmid=1
      [Wed Nov 06 12:32:38 2013] [error] [client ::1] PHP   1. {main}() /Users/danp/moodles/im/moodle/mod/glossary/edit.php:0, referer: http://dan.moodle.local/im/mod/glossary/edit.php?cmid=1
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dmonllao David Monllaó
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Marina Glancy
                Integrator:
                Dan Poltawski
                Tester:
                Dan Poltawski
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14