Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42752

Disabled icons on file picker still get focus resulting in them being read out by screen readers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6, 2.6.4, 2.7.1
    • Fix Version/s: 2.6.5, 2.7.2
    • Component/s: Filepicker
    • Labels:
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42752-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Load a file picker.
      2. Swap to a repository that doesn't use the view buttons
      3. Try to tab to the view buttons
      • you shouldn't be able to any more
      1. Ensure styling is correct on all supported browsers
      Show
      Load a file picker. Swap to a repository that doesn't use the view buttons Try to tab to the view buttons you shouldn't be able to any more Ensure styling is correct on all supported browsers
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 13

      Description

      When tabbing through the icons on the filepicker, you can focus on ones that are disabled. This results in a screen reader reading them out to the user, even though it shouldn't.

      As an additional part of this issue, it would be good to look at the alt/title attribute pairing of the icons, and see if there is a way to improve this. Also, the strings used for the tooltips should be escaped using y.html.escape

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. CONTRIB-5175 False positives with preg /e checker

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42631 Icons on the filepicker/manager toolbar need tooltips to help understand what they do

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              phalacee Jason Fowler
              Reporter:
              phalacee Jason Fowler
              Peer reviewer:
              Andrew Davis Andrew Davis
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Mark Nelson Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14