Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42775

core_dml_testcase::test_coalesce() failure on oracle

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.6
    • 2.6, BACKEND
    • Unit tests

    Description

      There was 1 failure:
       
      1) core_dml_testcase::test_coalesce
      Failed asserting that null is identical to ''.
       
      /home/fred/www/repositories/im_oracle/moodle/lib/dml/tests/dml_test.php:3785
      /home/fred/www/repositories/im_oracle/moodle/lib/phpunit/classes/database_driver_testcase.php:143
       
      To re-run:
       vendor/bin/phpunit core_dml_testcase lib/dml/tests/dml_test.php
      

      Eloy says:

      We used to have $DB->sql_empty() but was deprecated in favor of passing any empty string as parameter.
      So, IMO that test is wrong and it should be passing parameters. But that is exactly tested by the next assertion (#3787). So I'd propose to, simply, get rid of that problematic assertion.
      That or we revive (un-deprecate) $DB->sql_empty().

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Marina Glancy Marina Glancy
              Frédéric Massart Frédéric Massart
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13