Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42799

Grading with editpdf generate 'Division by zero' warning

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Before patch do the following:
        • As teacher create an assignment
        • As student submit pdf
        • As teacher give feedback with editpdf and add rectangle with 0 width/height (select rect and click on view area, don't drag mouse)
        • Draw circle/image etc with 0 width/height and make sure you don't see anything
        • Save feedback and you should see divide by zero error.
      2. Apply patch and go to editpdf
      3. make sure you can't add any circle/rectangle etc with width/height < 5px.
      4. Highlight should be min 5px width
      5. Stamp should be min 40px
      6. Save feedback and you should not get divide by zero error.

      Test other functionalities and make sure all works as expected.

      Show
      Before patch do the following: As teacher create an assignment As student submit pdf As teacher give feedback with editpdf and add rectangle with 0 width/height (select rect and click on view area, don't drag mouse) Draw circle/image etc with 0 width/height and make sure you don't see anything Save feedback and you should see divide by zero error. Apply patch and go to editpdf make sure you can't add any circle/rectangle etc with width/height < 5px. Highlight should be min 5px width Stamp should be min 40px Save feedback and you should not get divide by zero error. Test other functionalities and make sure all works as expected.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-mdl-42799

      Description

      Grade student pdf file submission with editpdf tools. Upon saving it, the following error occurs:

      Warning: Division by zero in /integration/master/lib/tcpdf/tcpdf.php on line 11690 
      Warning: Division by zero in /integration/master/lib/tcpdf/tcpdf.php on line 11691 
      

        Attachments

        1. sample.pdf
          214 kB
          Rossiani Wijaya

          Activity

            People

            Assignee:
            rajeshtaneja Rajesh Taneja
            Reporter:
            rwijaya Rossiani Wijaya
            Peer reviewer:
            Damyon Wiese
            Integrator:
            Marina Glancy
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/13