Moodle
  1. Moodle
  2. MDL-42842

Change mod/data availability to date_time_selector

    Details

    • Testing Instructions:
      Hide
      • Create a couse
      • Add a data activity module
        • Set "timeavailablefrom" and "timeviewfrom" to today, 00:00
        • Set "timeavailableto" and "timeviewto" to today, one hour in the future
      • Try to access the activity and see that it is open
      Show
      Create a couse Add a data activity module Set "timeavailablefrom" and "timeviewfrom" to today, 00:00 Set "timeavailableto" and "timeviewto" to today, one hour in the future Try to access the activity and see that it is open
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      With this change teachers can correctly select the availability selecting the date and minute, not only the date.

      Replication steps:

      • Create a couse
      • Add a data activity module
        • Set "timeavailablefrom" and "timeviewfrom" to today
        • Set "timeavailableto" and "timeviewto" to today
      • Try to access the activity and see that it is not open

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Daniel Neis added a comment -

            The patch is on github.

            Show
            Daniel Neis added a comment - The patch is on github.
            Hide
            Michael de Raadt added a comment -

            Thanks for suggesting this and providing a patch.

            Show
            Michael de Raadt added a comment - Thanks for suggesting this and providing a patch.
            Hide
            Tim Hunt added a comment -

            If you are puzzled by a mysterious behat commit from 20th November 2013, that mentions this issue number, then you are actually looking for MDL-42942.

            Show
            Tim Hunt added a comment - If you are puzzled by a mysterious behat commit from 20th November 2013, that mentions this issue number, then you are actually looking for MDL-42942 .
            Hide
            Daniel Neis added a comment - - edited

            Hello, Michael

            could you please review this one? It is similar to MDL-41173

            Kind regards,
            Daniel

            Show
            Daniel Neis added a comment - - edited Hello, Michael could you please review this one? It is similar to MDL-41173 Kind regards, Daniel
            Hide
            Michael de Raadt added a comment -

            Hi, Daniel.

            I won't peer review this for you, but I can go better than that.

            First, I've added you to the developers group and assigned this issue to you.

            I've also set this to the correct state of Waiting for Peer review so any developer can take on the peer review and potentially push it to integration.

            Show
            Michael de Raadt added a comment - Hi, Daniel. I won't peer review this for you, but I can go better than that. First, I've added you to the developers group and assigned this issue to you. I've also set this to the correct state of Waiting for Peer review so any developer can take on the peer review and potentially push it to integration.
            Hide
            CiBoT added a comment -

            Results for MDL-42842

            • Error: the repository field is empty. Nothing was checked.
            Show
            CiBoT added a comment - Results for MDL-42842 Error: the repository field is empty. Nothing was checked.
            Hide
            Dan Poltawski added a comment -

            Hi Daniel,

            Thanks for the patch! Could you rebase your change on the latest 2.7 and fill out the branch and repository information on the tracker, then I think this issue will be good to go.

            Cheers,
            Dan

            Show
            Dan Poltawski added a comment - Hi Daniel, Thanks for the patch! Could you rebase your change on the latest 2.7 and fill out the branch and repository information on the tracker, then I think this issue will be good to go. Cheers, Dan
            Hide
            Daniel Neis added a comment -

            Hello, Dan

            i've rebased the change and filled the information that was missing.

            Kind regards,
            Daniel

            Show
            Daniel Neis added a comment - Hello, Dan i've rebased the change and filled the information that was missing. Kind regards, Daniel
            Show
            CiBoT added a comment - Results for MDL-42842 Remote repository: https://github.com/danielneis/moodle Remote branch MDL-42842 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1641 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1641/artifact/work/smurf.html
            Hide
            Dan Poltawski added a comment -

            Thanks Daniel, I'm sending this for integration.

            Note that cibot has complained about the lack of spaces between operators - that was an existing problem, but if you are feeling especially helpful you could update the patch to clear those coding style problems at the same time.

            Show
            Dan Poltawski added a comment - Thanks Daniel, I'm sending this for integration. Note that cibot has complained about the lack of spaces between operators - that was an existing problem, but if you are feeling especially helpful you could update the patch to clear those coding style problems at the same time.
            Hide
            Daniel Neis added a comment -

            Hello, Dan

            i liked the "especially helpful" feeling, so i updated the patch to be ok with the coding style =)

            Kind regards,
            Daniel

            Show
            Daniel Neis added a comment - Hello, Dan i liked the "especially helpful" feeling, so i updated the patch to be ok with the coding style =) Kind regards, Daniel
            Hide
            Dan Poltawski added a comment -

            Many thanks!

            Show
            Dan Poltawski added a comment - Many thanks!
            Hide
            CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            Damyon Wiese added a comment -

            Thanks for being "especially helpful"!

            This has been integrated to master only.

            Cheers!

            Show
            Damyon Wiese added a comment - Thanks for being "especially helpful"! This has been integrated to master only. Cheers!
            Hide
            Frédéric Massart added a comment - - edited

            Sorry but I need to fail this. I am not sure if the bug I found is related to the change or not. What happens is that when clicking the date "icon" of different fields, the data of one fields get reported in the other one.

            Replication steps:

            1. Set a different date on each date fields
            2. Open the last date selector (click the icon)
            3. Click on the icon of the one above (without closing the first one)
            4. Repeat till you reach the top
            5. Click again the icon of the last date selector

            Result: The date of the first field gets populated in the last one

            NB: The testing instructions could mention that we need to test the date selector - or not, sorry if I misunderstood.

            Ok, so apparently I misunderstood what was supposed to be tested. So I can now tell that the time is taken in account for the access time of the activity. So if the issue above is unrelated, this test can pass.

            Show
            Frédéric Massart added a comment - - edited Sorry but I need to fail this. I am not sure if the bug I found is related to the change or not. What happens is that when clicking the date "icon" of different fields, the data of one fields get reported in the other one. Replication steps: Set a different date on each date fields Open the last date selector (click the icon) Click on the icon of the one above (without closing the first one) Repeat till you reach the top Click again the icon of the last date selector Result: The date of the first field gets populated in the last one NB: The testing instructions could mention that we need to test the date selector - or not, sorry if I misunderstood. Ok, so apparently I misunderstood what was supposed to be tested. So I can now tell that the time is taken in account for the access time of the activity. So if the issue above is unrelated, this test can pass.
            Hide
            Damyon Wiese added a comment -

            Thanks Fred, this is a simple patch - the wierdness you see will be caused by MDL-32917 - I have failed that issue.

            I'll pass this as it is unrelated to this change.

            Show
            Damyon Wiese added a comment - Thanks Fred, this is a simple patch - the wierdness you see will be caused by MDL-32917 - I have failed that issue. I'll pass this as it is unrelated to this change.
            Hide
            Damyon Wiese added a comment -

            Passing for Fred.

            Show
            Damyon Wiese added a comment - Passing for Fred.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            For fun: http://www.youtube.com/watch?v=IGENkpaPkgw

            Many thanks for your hard work, this is now part of Moodle!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - For fun: http://www.youtube.com/watch?v=IGENkpaPkgw Many thanks for your hard work, this is now part of Moodle! Ciao
            Hide
            Mary Cooch added a comment -

            Removing docs_required label as this is documented here http://docs.moodle.org/27/en/Database_activity_settings - please check and amend if necessary.

            Show
            Mary Cooch added a comment - Removing docs_required label as this is documented here http://docs.moodle.org/27/en/Database_activity_settings - please check and amend if necessary.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: