Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42849

Fix padding issues on site frontpage with new edit menus

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: JavaScript, Themes
    • Labels:
    • Testing Instructions:
      Hide

      On front page:

      • Turn editing on
      • Add an activity which supports group modes (e.g. a forum)
      • Add an activity which does not (e.g. folder)
      • Looking at the edit menus for those activities
        • Confirm that they are vertically aligned
        • *Confirm that there's a reasonable amount of space between the Edit caret, and the Groups mode icon"

      Test in RTL and make sure groups mode icon is placed correctly.

      Show
      On front page: Turn editing on Add an activity which supports group modes (e.g. a forum) Add an activity which does not (e.g. folder) Looking at the edit menus for those activities Confirm that they are vertically aligned *Confirm that there's a reasonable amount of space between the Edit caret, and the Groups mode icon" Test in RTL and make sure groups mode icon is placed correctly.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42849-master
    • Pull Master Diff URL:

      Description

      A few people have mentioned that they keep clicking the group sicon instead of the dropdown on edit. I think we need to increase the padding or margin a few pixels to help prevent this.

      Marina has also pointed out that we're missing a selector on the standard theme for the 'filler' so the edit icons no longer line up on standard theme if you have an activity which does not support groups mode.

        Attachments

        1. frontpage_edit_group.png
          frontpage_edit_group.png
          9 kB
        2. rtl_padding_course_standard.png
          rtl_padding_course_standard.png
          16 kB
        3. rtl_padding_course.png
          rtl_padding_course.png
          16 kB
        4. rtl_padding_frontpage_standard.png
          rtl_padding_frontpage_standard.png
          12 kB
        5. rtl_padding_frontpage.png
          rtl_padding_frontpage.png
          12 kB
        6. ss1.png
          ss1.png
          11 kB
        7. ss2.png
          ss2.png
          6 kB
        8. ss3.png
          ss3.png
          6 kB
        9. ss4.png
          ss4.png
          6 kB

          Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-40975 Review new course editing interface

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Marina Glancy
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13