Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42858

No option to make the subcategories visible when category is hidden

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.1
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Create course categories with sub-categories
      2. On parent category, select the visibility icon to make it invisible. Make sure the visibility icon is available for sub-categories and it should be dimmed
      3. On parent category, select the visibility icon to make it visible. Make sure the visibility icon is available for sub-categories and it should display as available (not dimmed).
      4. Repeat the above steps for clean and standard.
      Show
      Create course categories with sub-categories On parent category, select the visibility icon to make it invisible. Make sure the visibility icon is available for sub-categories and it should be dimmed On parent category, select the visibility icon to make it visible. Make sure the visibility icon is available for sub-categories and it should display as available (not dimmed). Repeat the above steps for clean and standard.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull 2.6 Branch:
      MDL-42858_m26
    • Pull Master Branch:

      Description

      On 2.5 and 2.4, there is an option to show the subcategory when the category is hidden but there is none for 2.6

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rwijaya Rossiani Wijaya added a comment -

            Logically, I think it makes sense for not having the option to display the category when the parent is hidden. As Barbara mentioned on the description, the option is available in 2.5 version.

            Hi Sam,
            What is your suggestion for this issue, should we have this option available in 2.6?

            Show
            rwijaya Rossiani Wijaya added a comment - Logically, I think it makes sense for not having the option to display the category when the parent is hidden. As Barbara mentioned on the description, the option is available in 2.5 version. Hi Sam, What is your suggestion for this issue, should we have this option available in 2.6?
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Rosie,

            Definitely a regression (loss of functionality).
            I was over zealous there, hopefully an easy fix however. The icons will have been hidden by CSS, fingers crossed its as simple as removing the rule to hiding them.
            What I don't know is whether there is backend logic to prevent it. I've re-used existing API where possible so fingers crossed no changes required there.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Rosie, Definitely a regression (loss of functionality). I was over zealous there, hopefully an easy fix however. The icons will have been hidden by CSS, fingers crossed its as simple as removing the rule to hiding them. What I don't know is whether there is backend logic to prevent it. I've re-used existing API where possible so fingers crossed no changes required there. Cheers Sam
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Rosie - changes look spot on! pushing this into the integration queue straight away.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Rosie - changes look spot on! pushing this into the integration queue straight away.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master and 2.6 - thanks Rosie

            Show
            poltawski Dan Poltawski added a comment - Integrated to master and 2.6 - thanks Rosie
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Rosie,

            Unfortunately this is breaking a few php unit tests, could you update them?

            core_course_management_helper_test.test_action_category_hide_and_show
            core_course_management_helper_test.test_action_category_hide_and_show_by_id

            http://integration.moodle.org/job/20.%20Run%20phpunit%20UnitTests%20(master)/2061/

            Show
            poltawski Dan Poltawski added a comment - Hi Rosie, Unfortunately this is breaking a few php unit tests, could you update them? core_course_management_helper_test.test_action_category_hide_and_show core_course_management_helper_test.test_action_category_hide_and_show_by_id http://integration.moodle.org/job/20.%20Run%20phpunit%20UnitTests%20(master)/2061/
            Show
            rwijaya Rossiani Wijaya added a comment - - edited Hi Dan, I updated the patch for phpunit. Master: https://github.com/rwijaya/moodle/commit/5bc5e693d3646ab0db2e9cd96de2f1b89b99726a 26: https://github.com/rwijaya/moodle/commit/b412f014dea3a1409b6143a1d2b6690f317b3e13 Thank you.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Rosie, back to testing.

            Show
            poltawski Dan Poltawski added a comment - Thanks Rosie, back to testing.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Rosie, tested and passed.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Rosie, tested and passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations, this change has now made its way upstream. Thanks for your contribution!

            “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

            Show
            poltawski Dan Poltawski added a comment - Congratulations, this change has now made its way upstream. Thanks for your contribution! “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14