[MDL-42863] Capabilities overview breaks if there is a missing context. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-42863~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-42863
Testing Instructions:
Hide

The easiest way to test this is to hack directly in the database:

Make a new override somewhere through the UI.

In the DB, edit the context of that override, and change the context path so that the parent context is something that does not exist.

Then, go to Admin -> Users -> Permissions -> Capability overview and run the report for the capability you overrode.

Verify that you can see the report for all the context where things are fine. The context where you broke the path just will not show up.
Show
The easiest way to test this is to hack directly in the database: Make a new override somewhere through the UI. In the DB, edit the context of that override, and change the context path so that the parent context is something that does not exist. Then, go to Admin -> Users -> Permissions -> Capability overview and run the report for the capability you overrode. Verify that you can see the report for all the context where things are fine. The context where you broke the path just will not show up.

Suppose that, due to a past bug, you have some a role_capability that points to a non-existent contextid.

In this case tool_capability dies with a fatal error. It should do handle it better.

Participants:: Eloy Lafuente (stronk7), Frédéric Massart, Petr Skoda, Sam Hemelryk, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo