Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42876

Screen reader does not trigger the keyboard move

    Details

      Description

      Clicking on any four-pointed move icon (blocks, sections, activities) launches a window with move locations. However, this window is not triggered when navigating through a course page using the keyboard with a screen reader.

      The point of this feature is specifically for screenreaders - but they need to be in a certain mode to trigger the window.

      The fix is to add the ARIA role "button" to the icons.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Need to test thoroughly with various SRs including Jaws.

            Show
            dobedobedoh Andrew Nicols added a comment - Need to test thoroughly with various SRs including Jaws.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Sending to peer-review. Note that I'm now not able to reproduce even with Jaws. BWhen I first looked at the issue I could reproduce and the patch did fix the problem. But since I have big troubles to reproduce the issue (the activity drag and drop doesn't trigger the navigation on a space key).

            Show
            jerome Jérôme Mouneyrac added a comment - Sending to peer-review. Note that I'm now not able to reproduce even with Jaws. BWhen I first looked at the issue I could reproduce and the patch did fix the problem. But since I have big troubles to reproduce the issue (the activity drag and drop doesn't trigger the navigation on a space key).
            Hide
            damyon Damyon Wiese added a comment -

            JAWs has 2 different navigation modes - this will work in one mode and not in the other.

            Show
            damyon Damyon Wiese added a comment - JAWs has 2 different navigation modes - this will work in one mode and not in the other.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Hi Jerome,

            I tested with NVDA and the patch works as it should be.

            I also noticed that going through the list of links on the popup could only be done through tab key.

            The test should mentioned to test it on different screen reader and go through the items on the popup list with tab.

            Other that that, this looks great. Please feel free to submit for integration review.

            [y] Syntax
            [y] Whitespace
            [y] Output
            [-] Language
            [-] Databases
            [y] Testing (instructions and automated tests)
            [-] Security
            [-] Documentation
            [y] Git
            [-] Third party code
            [y] Sanity check

            Show
            rwijaya Rossiani Wijaya added a comment - Hi Jerome, I tested with NVDA and the patch works as it should be. I also noticed that going through the list of links on the popup could only be done through tab key. The test should mentioned to test it on different screen reader and go through the items on the popup list with tab. Other that that, this looks great. Please feel free to submit for integration review. [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [-] Third party code [y] Sanity check
            Hide
            jerome Jérôme Mouneyrac added a comment -

            I'm not sure what are the different Jaws navigation modes. I tried the following recommendation of mozilla http://www.mozilla.org/access/qa/win-webcontent-jaws.html to use Virtual PC mode. In both cases (on and off) it's working. I guess the current test instructions are at best as we know (I asked Damyon but the issue was only reported during an accessible meeting in speaking without mentioning what was the navigation mode)

            Show
            jerome Jérôme Mouneyrac added a comment - I'm not sure what are the different Jaws navigation modes. I tried the following recommendation of mozilla http://www.mozilla.org/access/qa/win-webcontent-jaws.html to use Virtual PC mode. In both cases (on and off) it's working. I guess the current test instructions are at best as we know (I asked Damyon but the issue was only reported during an accessible meeting in speaking without mentioning what was the navigation mode)
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Cheers Jerome - this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Cheers Jerome - this has been integrated now.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Passing as this bit works, but I'm going to raise a few more issues relating to this.

            We currently don't follow most of http://www.w3.org/WAI/PF/aria-practices/#dragdrop

            Show
            dobedobedoh Andrew Nicols added a comment - Passing as this bit works, but I'm going to raise a few more issues relating to this. We currently don't follow most of http://www.w3.org/WAI/PF/aria-practices/#dragdrop
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for your contributions, this change is now upstream!

            “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

            Show
            poltawski Dan Poltawski added a comment - Thanks for your contributions, this change is now upstream! “ If debugging is the process of removing software bugs, then programming must be the process of putting them in. ” - Edsger Dijkstra

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14