Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42905

Backup progress: Pointless line of code should be deleted

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.1
    • Component/s: Backup
    • Labels:
      None

      Description

      There is a line of code in the backup progress class which does nothing (it sets a local variable). Initially I intended to set a class member variable but accidentally didn't; in the end, it's no longer necessary to set this variable at this point.

      (The variable in question is used to make sure we don't output progress more than once per second.)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Looks good to me. Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - Looks good to me. Submitting for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            quen Sam Marshall added a comment -

            Rebased.

            Show
            quen Sam Marshall added a comment - Rebased.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys this has been integrated now
            Hide
            skodak Petr Skoda added a comment -

            works for me, thanks

            Show
            skodak Petr Skoda added a comment - works for me, thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            ...
            But still, I thank you, for you made me stronger…

            Stronger as the beast that roar in the wild
            Stronger as the storm across the ocean
            Stronger as the diamond that won’t break
            Stronger enough to take all heart aches….

            I thank you my friend, for you made me stronger…

            ---- Juneah Landicho

            Closing as fixed. Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - ... But still, I thank you, for you made me stronger… Stronger as the beast that roar in the wild Stronger as the storm across the ocean Stronger as the diamond that won’t break Stronger enough to take all heart aches…. I thank you my friend, for you made me stronger… ---- Juneah Landicho Closing as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14