Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.5, 2.6
-
Component/s: Groups
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
The new groups cache returns unexpected results when you pass in a field parameter than would normally change the result array index
Gliffy Diagrams
Attachments
Issue Links
- is a regression caused by
-
MDL-34398 Develop grouplib caching
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Thanks for spotting that and sharing a fix.
I wonder if you could transform your testing instructions so that they can be tested through the interface.
It's likely that this will have unit tests amended/added.
Hi Michael,
It does not appear you can trigger this issue using core Moodle interface, it's an issue that involves contrib code / customisations.
It also appears as if this is the only function in that file that is affected.
Cheers,
Aaron
Hi Aaron,
The fix looks ok to me.
I think we really need a unit test for this, then it would be good for integration.
Unit tests added
Thanks Dan 
Thanks Aaron, Integrated to 25, 26 and master.
Noting for others that the cache was introduced here in 25 - so no patch is needed for 24 - but we are still backporting to 24 for a little while yet.
I tested this in integration.
Passing!
Congratulations, this change has now made its way upstream. Thanks for your contribution!
“ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne
I have attached an example fix for one of the group functions as an example of how I think it should be fixed.