Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42924

use normalize_component to extract plugin name and type

    Details

    • Testing Instructions:
      Hide

      Not sure if this needs testing.

      Test

      1. To test create a copy of portfolio/mahara and refractor it to my_course
      2. Install and check mnet services are published for my_course and you don't see any error.
      Show
      Not sure if this needs testing. Test To test create a copy of portfolio/mahara and refractor it to my_course Install and check mnet services are published for my_course and you don't see any error.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-mdl-42924
    • Sprint:
      BACKEND Sprint 7
    • Story Points (Obsolete):
      5
    • Sprint:
      BACKEND Sprint 7

      Description

      file: moodle \ lib \ upgradelib.php
      function: function upgrade_plugin_mnet_functions ($ component)
      line: list ($ type, $ plugin) = explode ('_', $ component);

      If a plugin or block, etc. have a two-membered name eg "block_my_courses"
      the variable $plugin substituted is set to 'my' and should be 'my_courses'

      Should look like: list ($ type, $ plugin) = normalize_component ($ component);

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for reporting this and providing patch Andrzej,

            I have created branch and put this in backlog.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for reporting this and providing patch Andrzej, I have created branch and put this in backlog.
            Hide
            skodak Petr Skoda added a comment - - edited

            looks ok, I wish this thing was already gone...

            Show
            skodak Petr Skoda added a comment - - edited looks ok, I wish this thing was already gone...
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Petr,

            Pushing it for integration.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Petr, Pushing it for integration.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Raj and Andrzej,

            Good bug report and thanks for the fix. Integrated to 24, 25, 26 and master.

            Show
            damyon Damyon Wiese added a comment - Thanks Raj and Andrzej, Good bug report and thanks for the fix. Integrated to 24, 25, 26 and master.
            Hide
            skodak Petr Skoda added a comment -

            no regressions detected, thanks

            Show
            skodak Petr Skoda added a comment - no regressions detected, thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations, this change has now made its way upstream. Thanks for your contribution!

            “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

            Show
            poltawski Dan Poltawski added a comment - Congratulations, this change has now made its way upstream. Thanks for your contribution! “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14