Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42928

Reimplement scroll locking for full-screen dialogues

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Open the login page
      • Open a help popup
        • confirm that the page scroll WAS NOT locked (help is non-modal)
      • Log in and edit your profile settings
      • Open the Filepicker to choose a new profile picture
        • Confirm that the page scroll WAS locked and scrolling the page around has no effect (the scroll bars may appear, but will be locked)
      • Close the Filepicker
        • Confirm you have control again
      • Open the Filepicker
        • Confirm that the scroll bars are once again locked
      • Open the WikiMedia plugin and search for something
      • Select an image to open it's sub-dialogue
        • Confirm that the page scroll is still locked
      • Select the image - both dialogues should close
        • Confirm that the scroll is back
      • navigate to a course
      • stay at the top of the page and open the activity chooser
        • Confirm that the scroll bars are once again locked
      • close it, and move down the page
      • re-open the activity chooser
        • Confirm that the scroll bars are once again locked
      Show
      Open the login page Open a help popup confirm that the page scroll WAS NOT locked (help is non-modal) Log in and edit your profile settings Open the Filepicker to choose a new profile picture Confirm that the page scroll WAS locked and scrolling the page around has no effect (the scroll bars may appear, but will be locked) Close the Filepicker Confirm you have control again Open the Filepicker Confirm that the scroll bars are once again locked Open the WikiMedia plugin and search for something Select an image to open it's sub-dialogue Confirm that the page scroll is still locked Select the image - both dialogues should close Confirm that the scroll is back navigate to a course stay at the top of the page and open the activity chooser Confirm that the scroll bars are once again locked close it, and move down the page re-open the activity chooser Confirm that the scroll bars are once again locked
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42928-master
    • Story Points:
      100
    • Sprint:
      FRONTEND Sprint 8

      Description

      IMO, this is a serious usability issue as many of our dialogues contain scrollable content. When these are open and you attempt to scroll, you'll find that the page scrolls too.

      Whilst this isn't a major issue for desktop computers, those using trackpads (predominantly laptops), and those with touch screens (predominantly tablets) who swipe to get down the list will find that the whole page starts to move once the bottom (or top) of the list is reached.

      In the case of the Activity Chooser, this is a serious regression.

      This patch re-introduces scroll locking but using a different method. Rather than removing the scrollbars, we instead set the scrollTop and scrollLeft to the positions they were in when the dialogue was opened. We do this on every scroll event.
      When the dialogue is closed, we stop forcing the scroll and release control back to the user.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14