Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42928

Reimplement scroll locking for full-screen dialogues

    XMLWordPrintable

Details

    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_26_STABLE
    • MDL-42928-master
    • Hide
      • Open the login page
      • Open a help popup
        • confirm that the page scroll WAS NOT locked (help is non-modal)
      • Log in and edit your profile settings
      • Open the Filepicker to choose a new profile picture
        • Confirm that the page scroll WAS locked and scrolling the page around has no effect (the scroll bars may appear, but will be locked)
      • Close the Filepicker
        • Confirm you have control again
      • Open the Filepicker
        • Confirm that the scroll bars are once again locked
      • Open the WikiMedia plugin and search for something
      • Select an image to open it's sub-dialogue
        • Confirm that the page scroll is still locked
      • Select the image - both dialogues should close
        • Confirm that the scroll is back
      • navigate to a course
      • stay at the top of the page and open the activity chooser
        • Confirm that the scroll bars are once again locked
      • close it, and move down the page
      • re-open the activity chooser
        • Confirm that the scroll bars are once again locked
      Show
      Open the login page Open a help popup confirm that the page scroll WAS NOT locked (help is non-modal) Log in and edit your profile settings Open the Filepicker to choose a new profile picture Confirm that the page scroll WAS locked and scrolling the page around has no effect (the scroll bars may appear, but will be locked) Close the Filepicker Confirm you have control again Open the Filepicker Confirm that the scroll bars are once again locked Open the WikiMedia plugin and search for something Select an image to open it's sub-dialogue Confirm that the page scroll is still locked Select the image - both dialogues should close Confirm that the scroll is back navigate to a course stay at the top of the page and open the activity chooser Confirm that the scroll bars are once again locked close it, and move down the page re-open the activity chooser Confirm that the scroll bars are once again locked
    • 100
    • FRONTEND Sprint 8

    Description

      IMO, this is a serious usability issue as many of our dialogues contain scrollable content. When these are open and you attempt to scroll, you'll find that the page scrolls too.

      Whilst this isn't a major issue for desktop computers, those using trackpads (predominantly laptops), and those with touch screens (predominantly tablets) who swipe to get down the list will find that the whole page starts to move once the bottom (or top) of the list is reached.

      In the case of the Activity Chooser, this is a serious regression.

      This patch re-introduces scroll locking but using a different method. Rather than removing the scrollbars, we instead set the scrollTop and scrollLeft to the positions they were in when the dialogue was opened. We do this on every scroll event.
      When the dialogue is closed, we stop forcing the scroll and release control back to the user.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41481 Background scrolling is not locked when using activity chooser in a mobile device with clean theme

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-39851 Full screen popup for mobile (filepicker/activitychooser)

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43664 JavaScript breaks on IE <= 8

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-43663 Mobile: scroll down the activity chooser, the course page is also scroll down.

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Closed
          will be (partly) resolved by

          Improvement - An enhancement to an existing Moodle feature. MDL-43932 Add profiles to the behat default config file

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Jérôme Mouneyrac Jérôme Mouneyrac
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Ankit Agarwal Ankit Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Mar/14